Review main Merged

49408[TASK] Remove prepared query option from Extbase Query Settings

Benni Mack CR +2 V +2 Normal +46 −51 updated 08/08/16, 14:07

Commit message

The option inside the QuerySettings is removed, as all queries
are handled via Doctrine DBAL in the future. The parameters
are automatically built as prepared statements anyway, and optimized
by the Database abstraction.

The implementation methods are marked as deprecated to allow
extensions to run with TYPO3 v7 and TYPO3 v8, even though the option
has no effect in the TYPO3 Database queries anymore.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1521

  1. Benni Mack uploaded patch set 1 08/06/16, 14:29

  2. TYPO3com voted on patch set 1 V +1 08/06/16, 14:32 Completed build in 03m 20s on Sat, 6 Aug, 04:32 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1884

  3. Benni Mack commented on patch set 1 CR -1 08/06/16, 15:13

    FYI: Nicole will check before I continue.
  4. Nicole Hummel commented on patch set 1 08/06/16, 20:13

    QuerySettingsInterface.php:173

    I would say that the interface function can be removed already.
  5. Nicole Hummel commented on patch set 1 08/06/16, 20:14

    I would deprecate both methods without removing them. This is a good deprecation strategy.
  6. Benni Mack uploaded patch set 2 08/08/16, 07:40

  7. Benni Mack updated the commit message in patch set 3 08/08/16, 07:41

  8. Benni Mack updated the commit message in patch set 4 08/08/16, 07:42

  9. TYPO3com voted on patch set 2 V +1 08/08/16, 07:43 Completed build in 03m 22s on Mon, 8 Aug, 09:43 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1900

  10. TYPO3com voted on patch set 3 V +1 08/08/16, 07:45 Completed build in 04m 23s on Mon, 8 Aug, 09:45 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1901

  11. TYPO3com voted on patch set 4 V +1 08/08/16, 07:48 Completed build in 05m 30s on Mon, 8 Aug, 09:48 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1902

  12. Benni Mack uploaded patch set 5 08/08/16, 08:37

  13. TYPO3com voted on patch set 5 V +1 08/08/16, 08:40 Completed build in 03m 16s on Mon, 8 Aug, 10:40 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1907

  14. Georg Ringer voted on patch set 5 CR +1 V +1 08/08/16, 08:44

  15. Daniel Goerz commented on patch set 6 08/08/16, 08:53

    Published edit on patch set 5.
  16. Daniel Goerz voted on patch set 6 CR +1 08/08/16, 08:53

  17. TYPO3com voted on patch set 6 V +1 08/08/16, 08:57 Completed build in 03m 53s on Mon, 8 Aug, 10:57 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1908

  18. Georg Ringer voted on patch set 6 CR +1 V +1 08/08/16, 09:17

  19. Nicole Hummel voted on patch set 6 CR +1 08/08/16, 12:43

  20. Christian Kuhn voted on patch set 6 CR +2 V +2 08/08/16, 14:07

  21. Gerrit merged patch set 6 08/08/16, 14:07