49408[TASK] Remove prepared query option from Extbase Query Settings
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Goerz +1
- Georg Ringer +1
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77432-ExtbasePreparedStatementQueryOption.rstnew+39 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+2 −46
- typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php1+0 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php+5 −0
Review log 1521
-
Benni Mack uploaded patch set 1 08/06/16, 14:29
-
TYPO3com voted on patch set 1 V +1 08/06/16, 14:32 Completed build in 03m 20s on Sat, 6 Aug, 04:32 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1884
-
Benni Mack commented on patch set 1 CR -1 08/06/16, 15:13
FYI: Nicole will check before I continue. -
Nicole Hummel commented on patch set 1 08/06/16, 20:13
QuerySettingsInterface.php:173I would say that the interface function can be removed already. -
Nicole Hummel commented on patch set 1 08/06/16, 20:14
I would deprecate both methods without removing them. This is a good deprecation strategy. -
Benni Mack uploaded patch set 2 08/08/16, 07:40
-
Benni Mack updated the commit message in patch set 3 08/08/16, 07:41
-
Benni Mack updated the commit message in patch set 4 08/08/16, 07:42
-
TYPO3com voted on patch set 2 V +1 08/08/16, 07:43 Completed build in 03m 22s on Mon, 8 Aug, 09:43 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1900
-
TYPO3com voted on patch set 3 V +1 08/08/16, 07:45 Completed build in 04m 23s on Mon, 8 Aug, 09:45 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1901
-
TYPO3com voted on patch set 4 V +1 08/08/16, 07:48 Completed build in 05m 30s on Mon, 8 Aug, 09:48 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1902
-
Benni Mack uploaded patch set 5 08/08/16, 08:37
-
TYPO3com voted on patch set 5 V +1 08/08/16, 08:40 Completed build in 03m 16s on Mon, 8 Aug, 10:40 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1907
-
Georg Ringer voted on patch set 5 CR +1 V +1 08/08/16, 08:44
-
Daniel Goerz commented on patch set 6 08/08/16, 08:53
Published edit on patch set 5. -
Daniel Goerz voted on patch set 6 CR +1 08/08/16, 08:53
-
TYPO3com voted on patch set 6 V +1 08/08/16, 08:57 Completed build in 03m 53s on Mon, 8 Aug, 10:57 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1908
-
Georg Ringer voted on patch set 6 CR +1 V +1 08/08/16, 09:17
-
Nicole Hummel voted on patch set 6 CR +1 08/08/16, 12:43
-
Christian Kuhn voted on patch set 6 CR +2 V +2 08/08/16, 14:07
-
Gerrit merged patch set 6 08/08/16, 14:07