Review main Merged

49410[TASK] Fix spelling of Content-Type headers

Michael Stucki CR +2 V +2 Easy +15 −15 updated 08/08/16, 07:20

Commit message

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Georg Ringer +1
  • Verified V +2
    • Morton Jonuschat +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 911

  1. Michael Stucki uploaded patch set 1 08/06/16, 23:57

  2. TYPO3com voted on patch set 1 V +1 08/07/16, 00:02 Completed build in 04m 50s on Sun, 7 Aug, 02:02 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1893

  3. Michael Stucki uploaded patch set 2 08/07/16, 00:03

  4. Michael Stucki commented on patch set 2 08/07/16, 00:04

    Patch set 2: Found one more occurence after searching for "Content-type" and "content-type".
  5. TYPO3com voted on patch set 2 V +1 08/07/16, 00:07 Completed build in 03m 20s on Sun, 7 Aug, 02:07 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1894

  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/07/16, 11:27

  7. Morton Jonuschat voted on patch set 2 CR +2 V +2 08/07/16, 11:57

  8. Gerrit merged patch set 2 08/07/16, 11:57

  9. Benni Mack commented on patch set 3 08/07/16, 13:33

    shouldn't we backport this to 7.6? btw. with PSR-7 this case is not possible anymore, as our HttpResponse class is taking care of that. so once we have "all PSR-7" code, it's easy :)
  10. Morton Jonuschat commented on patch set 3 08/07/16, 13:36

    This is a purely cosmetic fix since HTTP Headers are case insensitive, so I see no reason besides consistency for a backport.
  11. Michael Stucki commented on patch set 3 08/08/16, 07:20

    @Morton: I'm not sure if it's really just cosmetic. See the original bug description at #77427. It doesn't matter if case sensitive or not. If we write these headers as keys into arrays, they may be sent twice if both notations are used... @Benni: I also thought about backporting the change. IMHO it does not hurt even if we're not sure if there's any problem at all...