Review main Merged Breaking

49414[!!!][TASK] Drop TCA option showIfRTE for checkboxes

Benni Mack CR +2 V +2 Normal +124 −3 updated 08/30/16, 22:14

Commit message

The option showIfRTE on checkboxes did only show up
when the user had the RTE active. This option is removed and
not evaluated anymore in FormEngine.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1621

  1. Benni Mack uploaded patch set 1 08/08/16, 07:00

  2. TYPO3com voted on patch set 1 V +1 08/08/16, 07:04 Completed build in 03m 23s on Mon, 8 Aug, 09:04 AM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1899

  3. Andreas Kienast commented on patch set 1 08/08/16, 07:05

    Breaking ReST is missing
  4. Christian Kuhn commented on patch set 1 08/08/16, 19:06

    Fine with me. Could additionally have a TcaMigration that finds affected TCA config, drops them and throws a deprecation to hint devs for this then invalid option.
  5. Benni Mack uploaded patch set 2 08/22/16, 18:35

  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/22/16, 18:39

  7. TYPO3com voted on patch set 2 V -1 08/22/16, 18:40 Completed build in 04m 47s on Mon, 22 Aug, 08:40 PM Test Summary: 18656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2218

  8. Benni Mack uploaded patch set 3 08/22/16, 18:43

  9. Georg Ringer rebased onto patch set 4 08/22/16, 18:44

  10. TYPO3com voted on patch set 3 V +1 08/22/16, 18:46 Completed build in 02m 54s on Mon, 22 Aug, 08:46 PM Test Summary: 18656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2223

  11. TYPO3com voted on patch set 4 V +1 08/22/16, 18:48 Completed build in 04m 36s on Mon, 22 Aug, 08:48 PM Test Summary: 18656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2224

  12. Georg Ringer voted on patch set 4 CR +1 V +1 08/25/16, 05:13

  13. Benni Mack commented on patch set 4 CR -2 08/25/16, 06:39

    waiting for 8.3 release
  14. Benni Mack voted on patch set 4 CR 0 08/30/16, 21:09

  15. Benni Mack uploaded patch set 5 08/30/16, 21:10

  16. TYPO3com voted on patch set 5 V +1 08/30/16, 21:13 Completed build in 02m 42s on Tue, 30 Aug, 11:13 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2487

  17. Andreas Kienast voted on patch set 5 CR +1 08/30/16, 21:18

  18. Christian Kuhn voted on patch set 5 CR +1 V +1 08/30/16, 21:24

  19. Philipp Gampe voted on patch set 5 CR +1 V +1 08/30/16, 21:24

  20. Georg Ringer voted on patch set 5 CR +2 V +2 08/30/16, 22:14

  21. Gerrit merged patch set 5 08/30/16, 22:14