Review main Abandoned

49428[CLEANUP] Fix missusage of enumerations

Sascha Egerer CR 0 V 0 Hard +156 −106 updated 02/12/17, 12:04

Commit message

Enumerations should always be initialized via the static "cast" method.
They should also contain logic that is related to the enumeration like
the bitwise comparison in the Permissions enumeration.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 30

Show 10 more files

Review log 711

  1. Sascha Egerer uploaded patch set 1 08/09/16, 05:25

  2. TYPO3com voted on patch set 1 V -1 08/09/16, 05:33 Completed build in 07m 36s on Tue, 9 Aug, 07:33 AM Test Summary: 4 of 988 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1947

  3. Sascha Egerer uploaded patch set 2 08/09/16, 06:43

  4. TYPO3com voted on patch set 2 V -1 08/09/16, 06:49 Completed build in 06m 07s on Tue, 9 Aug, 08:49 AM Test Summary: 2 of 988 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1948

  5. Sascha Egerer commented on patch set 2 CR -2 08/09/16, 07:48

    ok i have to rethink that patch... does not make so much sense...
  6. Sascha Egerer uploaded patch set 3 08/31/16, 21:36

  7. TYPO3com voted on patch set 3 V -1 08/31/16, 21:39 Completed build in 02m 43s on Wed, 31 Aug, 11:39 PM Test Summary: 2 of 19100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2571

  8. Sascha Egerer uploaded patch set 4 09/01/16, 10:08

  9. TYPO3com voted on patch set 4 V -1 09/01/16, 10:18 Completed build in 10m 24s on Thu, 1 Sep, 12:18 PM Test Summary: 2 of 9961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2610

  10. Wouter Wolters commented on patch set 4 12/08/16, 21:46

    Sascha, still wanna finish this one?
  11. Sascha Egerer abandoned the change 02/12/17, 12:04

    No time to finish that one yet and i think there are much more places that have to be checked and refactored