Review main Merged

49441[TASK] Always keep <a> instead of <link> tags in RTE transformations

Benni Mack CR +2 V +2 Hard +61 −217 updated 01/12/17, 14:13

Commit message

The RTE uses <a> tags for handling links, a transformation
that replaces <link> tags to <a> tags is updated to use the
new t3:// linking syntax instead of hard-coding index.php?id=23
or trying to manually resolve the TypoLink functionality
for doing links.

This also means that the RTE now deals with t3:// links,
and HtmlArea is adapted as well.

When saving the links in the database again, the links
are now not transformed into <link> tags again but kept
as proper <a> tags.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 811

  1. Benni Mack uploaded patch set 1 08/10/16, 16:44

  2. TYPO3com voted on patch set 1 V +1 08/10/16, 16:47 Completed build in 02m 46s on Wed, 10 Aug, 06:47 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1976

  3. Benni Mack commented on patch set 1 CR -1 08/10/16, 18:16

    Although this works for now, we need to ensure that existing link tags (e.g. from l10nmgr) still transform from <link> tags to <a> tags. Gotta double check that. Also, we might need the removed functionality for the migration wizard.
  4. Benni Mack uploaded patch set 3 01/12/17, 12:22

  5. TYPO3com voted on patch set 3 V +1 01/12/17, 12:27 Completed build in 05m 43s on Thu, 12 Jan, 01:27 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6562

  6. Susi Moog commented on patch set 4 01/12/17, 12:29

    Published edit on patch set 3.
  7. TYPO3com voted on patch set 4 V +1 01/12/17, 12:33 Completed build in 04m 38s on Thu, 12 Jan, 01:33 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6563

  8. Susi Moog commented on patch set 4 V -1 01/12/17, 12:51

    sadly, after the path my frontend links with t3:// syntax are broken.
  9. Susi Moog commented on patch set 4 CR +1 V +1 01/12/17, 13:24

    do not use the bootstrap package to test this.
  10. Christian Kuhn voted on patch set 4 CR +2 V +2 01/12/17, 14:13

  11. Gerrit merged patch set 4 01/12/17, 14:13