Review main Merged

49455[BUGFIX] Correct wrong markup in Template module

Michael Oehlhof CR +2 V +2 Easy +2 −4 updated 08/16/16, 10:13

Commit message

This patch brings back the missing labels and text
and removes double form element.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Michael Oehlhof uploaded patch set 1 08/11/16, 14:10

  2. TYPO3com voted on patch set 1 V +1 08/11/16, 14:16 Completed build in 05m 26s on Thu, 11 Aug, 04:16 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2000

  3. Christian Kuhn commented on patch set 1 08/11/16, 20:20

    on pages without template, the "template tools" h1 is now duplicated.
  4. Christian Kuhn commented on patch set 1 08/11/16, 20:25

    TypoScriptTemplateModuleController.php:677

    this is identical to $extensionName as far as i can see.
  5. Christian Kuhn commented on patch set 1 08/11/16, 20:29

    and georg is correct - on the "no template" page, there *are* 3 nested form tags!
  6. Christian Kuhn voted on patch set 1 CR -1 08/11/16, 20:29

  7. Michael Oehlhof uploaded patch set 2 08/11/16, 21:40

  8. TYPO3com voted on patch set 2 V +1 08/11/16, 21:42 Completed build in 02m 18s on Thu, 11 Aug, 11:42 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2014

  9. Michael Oehlhof updated the commit message in patch set 3 08/11/16, 21:42

  10. Michael Oehlhof updated the commit message in patch set 4 08/11/16, 21:44

  11. TYPO3com voted on patch set 3 V +1 08/11/16, 21:45 Completed build in 02m 30s on Thu, 11 Aug, 11:45 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2015

  12. TYPO3com voted on patch set 4 V +1 08/11/16, 21:47 Completed build in 02m 33s on Thu, 11 Aug, 11:47 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2016

  13. Georg Ringer voted on patch set 4 CR +1 V +1 08/16/16, 06:15

  14. Christian Kuhn commented on patch set 4 08/16/16, 10:12

    ok, i'll merge this now. the module is bug fixed so far. Still, there are still two form elements. i'll ask mattes if he can have a look at that - it probably relates to the docheader implementation details.
  15. Christian Kuhn voted on patch set 4 CR +2 V +2 08/16/16, 10:13

  16. Gerrit merged patch set 4 08/16/16, 10:13