Review main Abandoned

49469[BUGFIX] Remove TCEForms element if other elements exists

Alexander Opitz CR 0 V 0 Easy +3 −0 updated 09/16/18, 23:49

Commit message

The TCA array needs to remove the TCEforms part also, also if another
extension have registered his data to an flex element like TemplaVoila.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1014

  1. Alexander Opitz uploaded patch set 1 08/12/16, 14:09

  2. TYPO3com voted on patch set 1 V -1 08/12/16, 14:12 Completed build in 02m 18s on Fri, 12 Aug, 04:12 PM Test Summary: 2 of 18668 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2027

  3. Alexander Opitz uploaded patch set 2 08/12/16, 14:41

  4. Oliver Klee commented on patch set 2 CR -1 08/12/16, 14:42

    TcaFlexPrepare.php:94

    This debug code probably should not be here. :-)
  5. TYPO3com voted on patch set 2 V -1 08/12/16, 14:44 Completed build in 02m 33s on Fri, 12 Aug, 04:44 PM Test Summary: 988 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2028

  6. Alexander Opitz uploaded patch set 3 08/12/16, 14:46

  7. Alexander Opitz commented on patch set 2 08/12/16, 14:46

    TcaFlexPrepare.php:94 Reply

    Done
  8. TYPO3com voted on patch set 3 V +1 08/12/16, 14:48 Completed build in 02m 45s on Fri, 12 Aug, 04:48 PM Test Summary: 18668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2029

  9. Christian Kuhn commented on patch set 3 CR -1 08/15/16, 10:40

    i would like to see a working TV extension first and afterwards look if we really need to bug fix smaller parts within core itself. the formEngine allows to substitute data provider with own classes - let's do that for the time being and if the TV extension works again, we have a better overview and could merge small and dedicated parts into the core again if really required.
  10. Alexander Schnitzler commented on patch set 3 12/28/16, 15:25

    Please have a look at this one again, Christian. As discussed in a private, the count check on the amount of children is too strict. Especially in TYPO3 8.x, where there is no possibility to step in between FlexFetch and FlexPrepare any more. However, I'd say we do not even need another elseif here. The trick would be to just remove the count check. Whatever people store besides <TCEforms> does not matter when it comes to the TCA processing. Alex, wdyt?
  11. Mathias Schreiber uploaded patch set 4 02/06/18, 19:12

  12. Mathias Schreiber commented on patch set 4 V -1 CR -1 02/06/18, 19:12

    Please re-add the respective unittests. These have change dramatically and I'm not deep enough into TemplaVoila to be helpful here
  13. TYPO3com voted on patch set 4 V +1 02/06/18, 19:18 Completed build in 06m 33s on Tue, 6 Feb, 08:18 PM Test Summary: 30440 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19030

  14. Christian Kuhn abandoned the change 09/16/18, 23:49

    hey alex. i'm abandoning this patch for now since nothing really happened here for more than 2 years. i'm also closing the issue. please feel free to resurrect the patch if work is continued here.