Review main Merged

49491[FEATURE] Allow EXT: syntax in PageRenderer and Compressor

Benni Mack CR +2 V +2 Normal +81 −90 updated 03/09/18, 14:11

Commit message

JS and CSS files can now be added via the EXT: syntax, to ease the
pain to a standardized way to include files with EXT: everywhere
now.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Philipp Gampe +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 2535

Show 610 earlier messages
  1. Benni Mack uploaded patch set 1 08/15/16, 21:45

  2. TYPO3com voted on patch set 1 V -1 08/15/16, 21:47 Completed build in 02m 12s on Mon, 15 Aug, 11:47 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2076

  3. Georg Ringer uploaded patch set 2 08/16/16, 09:51

  4. TYPO3com voted on patch set 2 V +1 08/16/16, 09:55 Completed build in 03m 29s on Tue, 16 Aug, 11:55 AM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2081

  5. Benni Mack uploaded patch set 3 08/22/16, 17:41

  6. TYPO3com voted on patch set 3 V +1 08/22/16, 17:44 Completed build in 02m 43s on Mon, 22 Aug, 07:44 PM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2210

  7. Benni Mack uploaded patch set 4 08/22/16, 17:56

  8. TYPO3com voted on patch set 4 V -1 08/22/16, 18:00 Completed build in 03m 17s on Mon, 22 Aug, 08:00 PM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2212

  9. Benni Mack uploaded patch set 5 08/22/16, 18:01

  10. Georg Ringer voted on patch set 4 CR +1 V +1 08/22/16, 18:01

  1. TYPO3com voted on patch set 5 V +1 08/22/16, 18:04 Completed build in 03m 23s on Mon, 22 Aug, 08:04 PM Test Summary: 18652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2215

  2. Georg Ringer voted on patch set 5 CR +1 V +1 08/22/16, 18:20

  3. Benni Mack uploaded patch set 6 08/22/16, 18:45

  4. TYPO3com voted on patch set 6 V +1 08/22/16, 18:50 Completed build in 04m 17s on Mon, 22 Aug, 08:50 PM Test Summary: 18652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2225

  5. Georg Ringer voted on patch set 6 CR +1 V +1 08/22/16, 19:05

  6. Georg Ringer uploaded patch set 7 08/23/16, 05:23

  7. TYPO3com voted on patch set 7 V +1 08/23/16, 05:26 Completed build in 02m 45s on Tue, 23 Aug, 07:26 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2235

  8. Georg Ringer voted on patch set 7 CR +1 V +1 08/23/16, 05:57

  9. Frank Nägler commented on patch set 7 CR +1 08/23/16, 07:06

    +1 on reading, looks very good
  10. Benni Mack uploaded patch set 8 08/23/16, 12:27

  11. TYPO3com voted on patch set 8 V +1 08/23/16, 12:30 Completed build in 02m 36s on Tue, 23 Aug, 02:30 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2251

  12. Benni Mack uploaded patch set 9 08/23/16, 12:57

  13. TYPO3com voted on patch set 9 V +1 08/23/16, 13:01 Completed build in 03m 18s on Tue, 23 Aug, 03:01 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2258

  14. Stefan Neufeind commented on patch set 9 CR +1 V +1 08/29/16, 12:04

    Didn't spot issues so far. Also watched out for similar places we might have missed. I like it.
  15. Andreas Kienast voted on patch set 9 CR +1 08/29/16, 13:13

  16. Benni Mack uploaded patch set 10 08/30/16, 21:09

  17. TYPO3com voted on patch set 10 V +1 08/30/16, 21:12 Completed build in 02m 49s on Tue, 30 Aug, 11:12 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2486

  18. Christian Kuhn voted on patch set 10 CR +1 08/30/16, 21:19

  19. Andreas Kienast voted on patch set 10 CR +1 V +1 08/30/16, 21:23

  20. Philipp Gampe voted on patch set 10 CR +1 08/30/16, 21:35

  21. Stefan Neufeind voted on patch set 10 CR +1 V +1 08/30/16, 22:26

  22. Benni Mack voted on patch set 10 CR +2 V +2 08/30/16, 22:30

  23. Gerrit merged patch set 10 08/30/16, 22:30

  24. Andreas Kienast commented on patch set 11 08/31/16, 07:34

    There is a regression with t3editor: GET ext:t3editor/Resources/Public/Css/t3editor.css net::ERR_UNKNOWN_URL_SCHEME
  25. Oliver Hader commented on patch set 11 03/09/18, 14:11

    PageRenderer.php:2757

    see #83630