Review main Abandoned

49495[BUGFIX] Add UTF-8 support to the fileDenyPattern

Tim Spiekerkötter CR 0 V 0 Easy +1 −1 updated 12/07/16, 14:40

Commit message

The preg_match call within verifyFilenameAgainstDenyPattern can handle
UTF-8 filenames with the /u modifier. On some systems this is needed,
otherwise filenames not matching the fileDenyPattern are refused by the
method.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Tim Spiekerkötter uploaded patch set 1 08/16/16, 10:55

  2. TYPO3com voted on patch set 1 V +1 08/16/16, 10:58 Completed build in 02m 47s on Tue, 16 Aug, 12:58 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2084

  3. Jörg Bösche voted on patch set 1 CR +1 08/18/16, 20:40

  4. Frederic Gaus voted on patch set 1 CR +1 08/19/16, 08:56

  5. Stefan Neufeind commented on patch set 1 CR +1 08/29/16, 12:41

    Technically seems to make sense. We use the u-modifier in other places as well. Are there similar places where this might make sense? What are the conditions for when u is needed or not needed (PHP-version, ...).
  6. Helmut Hummel commented on patch set 1 CR -2 10/07/16, 17:47

    this might be security relevant. please do not merge for now.
  7. Wouter Wolters abandoned the change 12/07/16, 14:40