49498[TASK] Deprecate ContentObjectRenderer::fileResource
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Wouter Wolters +1
-
Verified V +2
- Susi Moog +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php1+15 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77524-DeprecatedMethodFileResourceOfContentObjectRenderer.rst1new+32 −0
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php1+15 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −0
- typo3/sysext/frontend/Classes/ContentObject/FileContentObject.php4+24 −1
Review log 5268
Show 3343 earlier messages
-
Georg Ringer uploaded patch set 1 08/16/16, 15:45
-
TYPO3com voted on patch set 1 V -1 08/16/16, 15:49 Completed build in 03m 56s on Tue, 16 Aug, 05:49 PM Test Summary: 18683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2096
-
Georg Ringer uploaded patch set 2 08/16/16, 17:38
-
TYPO3com voted on patch set 2 V +1 08/16/16, 17:41 Completed build in 02m 43s on Tue, 16 Aug, 07:41 PM Test Summary: 18683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2098
-
Benni Mack updated the commit message in patch set 3 08/16/16, 21:09
-
TYPO3com voted on patch set 3 V +1 08/16/16, 21:12 Completed build in 02m 38s on Tue, 16 Aug, 11:12 PM Test Summary: 18683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2104
-
Oliver Klee voted on patch set 3 CR +1 08/17/16, 10:50
-
Frederic Gaus voted on patch set 3 CR +1 08/17/16, 11:33
-
Stefan Neufeind voted on patch set 3 CR +1 08/18/16, 13:18
-
Jörg Bösche voted on patch set 3 CR +1 08/18/16, 20:36
-
Benni Mack commented on patch set 3 08/21/16, 16:03
This is breaking, as the functionality of cObject FILE is changed as well, so this needs to be documented as well: https://docs.typo3.org/typo3cms/TyposcriptReference/ContentObjects/File/Index.html -
Benni Mack voted on patch set 3 CR -1 08/21/16, 16:03
-
Stefan Neufeind voted on patch set 3 CR -1 08/21/16, 16:48
-
Georg Ringer uploaded patch set 4 08/22/16, 19:22
-
TYPO3com voted on patch set 4 V +1 08/22/16, 19:25 Completed build in 03m 03s on Mon, 22 Aug, 09:25 PM Test Summary: 18652 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2231
-
Wouter Wolters commented on patch set 4 09/01/16, 14:25
Deprecation-77524-DeprecateMethodFileResourceOfContentObjectRenderer.rst:15using the mentioned what? -
Stefan Neufeind commented on patch set 4 09/01/16, 14:49
Deprecation-77524-DeprecateMethodFileResourceOfContentObjectRenderer.rst:15Replymaybe "the method" (that was mentioned in the description) -
Philipp Gampe commented on patch set 5 09/01/16, 14:50
Published edit on patch set 4. -
Philipp Gampe commented on patch set 4 09/01/16, 14:51
Deprecation-77524-DeprecateMethodFileResourceOfContentObjectRenderer.rst:15ReplyDone -
Philipp Gampe voted on patch set 5 CR +1 09/01/16, 14:51
-
TYPO3com voted on patch set 5 V +1 09/01/16, 14:53 Completed build in 03m 01s on Thu, 1 Sep, 04:53 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2645
-
Stefan Neufeind voted on patch set 5 CR +1 V +1 09/01/16, 14:55
-
Philipp Gampe voted on patch set 5 V +1 09/01/16, 14:57
-
Benni Mack commented on patch set 5 CR -1 09/01/16, 20:12
This can be solved without being breaking, basically as you did previously - just copy the functionality of the function into the FileContentObject - this way it's not breaking at all, and site owners don't need to worry. The extra functionality for rendering an <img> tag can then safely be deprecated separately. What do you think? -
Markus Klein commented on patch set 6 09/20/16, 12:38
Published edit on patch set 5. -
Markus Klein voted on patch set 6 CR +1 V +1 09/20/16, 12:38
-
Markus Klein commented on patch set 7 09/20/16, 12:41
Published edit on patch set 6. -
Markus Klein commented on patch set 8 09/20/16, 12:42
Published edit on patch set 7. -
Markus Klein voted on patch set 8 CR +1 V +1 09/20/16, 12:42
-
TYPO3com voted on patch set 6 V +1 09/20/16, 12:42 Completed build in 03m 26s on Tue, 20 Sep, 02:42 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3145
-
Stefan Neufeind voted on patch set 8 CR +1 09/20/16, 12:43
-
TYPO3com voted on patch set 7 V +1 09/20/16, 12:45 Completed build in 03m 54s on Tue, 20 Sep, 02:45 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3147
-
TYPO3com voted on patch set 8 V +1 09/20/16, 12:48 Completed build in 05m 53s on Tue, 20 Sep, 02:48 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3148
-
Benni Mack commented on patch set 8 09/20/16, 13:16
to make this change non-breaking, I recommend to copy the functionality from cObj to FileContentObject to achieve the same functionality as it was before. -
Benni Mack uploaded patch set 9 09/24/16, 14:15
-
Benni Mack voted on patch set 9 CR +1 09/24/16, 14:16
-
TYPO3com voted on patch set 9 V +1 09/24/16, 14:19 Completed build in 03m 29s on Sat, 24 Sep, 04:19 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3200
-
Wouter Wolters voted on patch set 9 CR +1 V +1 09/30/16, 08:19
-
Stefan Neufeind voted on patch set 9 CR +1 09/30/16, 08:23
-
Dmitry Dulepov commented on patch set 9 CR -1 09/30/16, 10:32
I have some notes after the code review. At least undefined variable should be fixed.SearchFormController.php:380As in other files, '0' or 'false' fails here.FrontendLoginController.php:146File names '0' or 'false' will fail. Should we fix this too?FileContentObject.php:34It would be nicer to have 34-45 in a separate function because it looks like a separate logical unit.FileContentObject.php:35Makes sense to test for null or === '' because the current code will not allow files with names '0' or 'false'.FileContentObject.php:40Undefined variable $addParams. -
Dmitry Dulepov uploaded patch set 10 10/03/16, 10:14
-
Dmitry Dulepov commented on patch set 10 CR +1 10/03/16, 10:16
Moving code from FIleContentObject is not worth it because there are more than one variable returned. So I only changed check for existence, so that files like '0' or 'false' do not fail, and removed unused var. -
TYPO3com voted on patch set 10 V +1 10/03/16, 10:18 Completed build in 03m 58s on Mon, 3 Oct, 12:18 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3314
-
Markus Klein commented on patch set 10 10/03/16, 18:01
Deprecation-77524-DeprecateMethodFileResourceOfContentObjectRenderer.rst:4Deprecated -
Markus Klein commented on patch set 11 10/03/16, 18:08
Published edit on patch set 10. -
Markus Klein voted on patch set 11 CR +1 10/03/16, 18:08
-
TYPO3com voted on patch set 11 V +1 10/03/16, 18:11 Completed build in 03m 16s on Mon, 3 Oct, 08:11 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3317
-
Jörg Bösche voted on patch set 11 CR +1 10/06/16, 10:05
-
Stefan Neufeind voted on patch set 11 CR +1 10/09/16, 23:22
-
Susi Moog voted on patch set 11 CR +1 V +1 10/13/16, 17:42
-
Benni Mack commented on patch set 11 CR -1 10/21/16, 08:53
FileContentObject.php:31we don't apply getAltParam() anymore in the new version, this is a bug -
Benni Mack commented on patch set 12 10/21/16, 11:03
Published edit on patch set 11. -
TYPO3com voted on patch set 12 V +1 10/21/16, 11:09 Completed build in 06m 00s on Fri, 21 Oct, 01:09 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3977
-
Anja Leichsenring uploaded patch set 13 12/04/16, 11:21
-
Anja Leichsenring commented on patch set 13 CR -1 12/04/16, 11:21
rebased, Bennis comment still applies -
TYPO3com voted on patch set 13 V -1 12/04/16, 11:44 Completed build in 23m 19s on Sun, 4 Dec, 12:44 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5487
-
Wouter Wolters uploaded patch set 14 12/07/16, 09:56
-
TYPO3com voted on patch set 14 V -1 12/07/16, 10:00 Completed build in 04m 38s on Wed, 7 Dec, 11:00 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5547
-
Wouter Wolters uploaded patch set 15 12/07/16, 10:10
-
TYPO3com voted on patch set 15 V +1 12/07/16, 10:14 Completed build in 03m 51s on Wed, 7 Dec, 11:14 AM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5550
-
Wouter Wolters voted on patch set 15 CR +1 V +1 12/07/16, 10:16
-
Stefan Neufeind commented on patch set 15 CR -1 12/07/16, 11:22
Deprecation-77524-DeprecatedMethodFileResourceOfContentObjectRenderer.rst:30others who migrate their code can't use the method from "$this", right? Should we mention to use the TSFE from GLOBALS? That we ourselves access the GLOBALS through a method is independent from that imho. -
Wouter Wolters commented on patch set 16 12/07/16, 11:39
Published edit on patch set 15. -
TYPO3com voted on patch set 16 V +1 12/07/16, 11:43 Completed build in 04m 02s on Wed, 7 Dec, 12:43 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5563
-
Wouter Wolters voted on patch set 16 CR +1 V +1 12/07/16, 11:44
-
Susi Moog voted on patch set 16 CR +2 V +2 12/07/16, 11:52
-
Gerrit merged patch set 16 12/07/16, 11:52
-
Stefan Neufeind commented on patch set 17 12/07/16, 12:05
thanks for taking care so quickly