Review main Merged

49532[BUGFIX] Continue searching after empty result

Alexander Jahn CR +2 V +2 Easy +1 −0 updated 08/23/16, 18:57

Commit message

Change the default behaviour of jQuery autocomplete to continue
searching for characters even if the search already returned nothing.

The standard behaviour of autocomplete is to stop searching after
no results were found.
However, this made it impossible to use commands.
Searching for '#content:12345' did not work when '#con' could not
be found. Search was not executed for subsequent characters.

The parameter 'preventBadQueries: false' is used to force
searching for every character entered.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Alexander Jahn uploaded patch set 1 08/22/16, 07:13

  2. TYPO3com voted on patch set 1 V +1 08/22/16, 07:16 Completed build in 03m 05s on Mon, 22 Aug, 09:16 AM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2182

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/22/16, 07:22

  4. Wouter Wolters commented on patch set 1 08/22/16, 07:30

    even "if" the search
  5. Benni Mack updated the commit message in patch set 2 08/22/16, 15:51

  6. Benni Mack voted on patch set 2 CR +1 V +1 08/22/16, 15:53

  7. TYPO3com voted on patch set 2 V +1 08/22/16, 15:55 Completed build in 03m 23s on Mon, 22 Aug, 05:54 PM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2201

  8. Wouter Wolters voted on patch set 2 CR +1 08/22/16, 18:44

  9. Georg Ringer voted on patch set 2 CR +2 V +2 08/23/16, 07:54

  10. Gerrit merged patch set 2 08/23/16, 07:54

  11. Wouter Wolters commented on patch set 3 08/23/16, 18:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 2aded7aa1627dec9878b667ee79e3674c5509c4e