Review main Merged

49537[BUGFIX] Fix source collection for GIFBUILDER

Marco Huber CR +2 V +2 Easy +7 −1 updated 02/20/18, 07:38

Commit message

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Review

  • Code review CR +2
    • Benni Mack +2
    • Tomas Norre Mikkelsen +1
    • Łukasz Uznański +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 3240

Show 1115 earlier messages
  1. Marco Huber uploaded patch set 1 08/22/16, 11:55

  2. Wouter Wolters updated the commit message in patch set 2 08/22/16, 11:56

  3. TYPO3com voted on patch set 1 V +1 08/22/16, 11:58 Completed build in 03m 23s on Mon, 22 Aug, 01:58 PM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2189

  4. TYPO3com voted on patch set 2 V +1 08/22/16, 11:59 Completed build in 03m 09s on Mon, 22 Aug, 01:59 PM Test Summary: 18654 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2190

  5. Benni Mack updated the commit message in patch set 3 09/02/16, 23:53

  6. Benni Mack voted on patch set 3 CR +1 09/02/16, 23:53

  7. TYPO3com voted on patch set 3 V +1 09/02/16, 23:57 Completed build in 03m 21s on Sat, 3 Sep, 01:57 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2815

  8. Philipp Gampe voted on patch set 3 CR +1 09/03/16, 00:50

  9. Andreas Kienast uploaded patch set 4 09/03/16, 07:26

  10. Andreas Kienast voted on patch set 4 CR +1 09/03/16, 07:26

  11. TYPO3com voted on patch set 4 V +1 09/03/16, 07:29 Completed build in 03m 13s on Sat, 3 Sep, 09:29 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2829

  12. Tymoteusz Motylewski commented on patch set 4 CR -1 09/03/16, 08:02

    ContentObjectRenderer.php:1319

    where is the maxWidth and maxHeight used?

    ContentObjectRenderer.php:5967

    is this change made on purpose?
  13. Andreas Kienast commented on patch set 4 09/03/16, 08:04

    ContentObjectRenderer.php:1319 Reply

    As far as I understood the code, those values are used as properties in $sourceRenderConfiguration a few lines below.
  14. Tymoteusz Motylewski commented on patch set 4 09/03/16, 08:24

    ContentObjectRenderer.php:1319 Reply

    I can see that, but where are they evaluated? or in other words how can I test that they work?
  15. Marco Huber commented on patch set 4 09/03/16, 08:43

    ContentObjectRenderer.php:1319 Reply

    'width', 'height', 'maxW', 'minW', 'maxH', 'minH' are use by the imageResource object (https://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Imgresource/Index.html#imgresource, \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::getImgResource). 'maxWidth', 'maxHeight', 'XY' are used by the GIFBUILDER object (https://docs.typo3.org/typo3cms/TyposcriptReference/Gifbuilder/ObjectNames/Index.html, \TYPO3\CMS\Frontend\Imaging\GifBuilder::start) and because they limit the image dimension there, I think they have to be rewritten here, too.

    ContentObjectRenderer.php:5967 Reply

    I don't know where this change comes from. It wasn't in my first patch,
  1. Marco Huber uploaded patch set 5 09/03/16, 09:44

  2. TYPO3com voted on patch set 5 V +1 09/03/16, 09:48 Completed build in 03m 31s on Sat, 3 Sep, 11:48 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2856

  3. Marco Huber commented on patch set 4 09/03/16, 09:52

    I added some more test examples to the ticket (and found a bug in my patch while writing this tests :-))
  4. Morton Jonuschat commented on patch set 5 CR -1 09/04/16, 09:03

    ContentObjectRenderer.php:1333

    use GeneralUtility::intExplode here and the int casts in the following lines can be dropped.

    ContentObjectRenderer.php:5967

    Drop this line.
  5. Andreas Kienast uploaded patch set 6 09/04/16, 09:07

  6. TYPO3com voted on patch set 6 V +1 09/04/16, 09:10 Completed build in 03m 05s on Sun, 4 Sep, 11:10 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2959

  7. Marco Huber commented on patch set 6 09/04/16, 10:04

    ContentObjectRenderer.php:5961

    I'm still not sure, if we should really drop this two lines. $page2 is needed some lines below, and I think this lines has been removed accidantly.
  8. Morton Jonuschat commented on patch set 6 10/09/16, 15:06

    ContentObjectRenderer.php:5961 Reply

    My remark was aimed at the stray // S comment. If the variable is used further down in the code we must keep it, I didn't check that initially.
  9. Marco Huber commented on patch set 7 10/10/16, 08:50

    Published edit on patch set 6.
  10. Marco Huber commented on patch set 7 10/10/16, 08:52

    I readded the two lines. I think now everything should be ok and this patch can be merged.
  11. TYPO3com voted on patch set 7 V +1 10/10/16, 08:55 Completed build in 04m 34s on Mon, 10 Oct, 10:55 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3554

  12. Jörg Bösche voted on patch set 7 CR +1 10/28/16, 21:17

  13. Morton Jonuschat voted on patch set 7 CR +1 12/31/16, 05:04

  14. Frank Nägler commented on patch set 7 CR -1 03/22/17, 21:31

    please see my inline comment, this change should be covered by the unit tests, means please add some tests for the new special case "XY"

    ContentObjectRenderer.php:1332

    XY can contain calculation informations. please see the introduction in the docu: https://docs.typo3.org/typo3cms/TyposcriptReference/Gifbuilder/Gifbuilder/Index.html
  15. Morton Jonuschat wrote 04/08/17, 05:29

    Removed the following votes: * Code-Review+1 by Morton Jonuschat <m.jonuschat@mojocode.de>
  16. Benni Mack updated the commit message in patch set 8 11/24/17, 21:46

  17. TYPO3com voted on patch set 8 V +1 11/24/17, 22:02 Completed build in 15m 29s on Fri, 24 Nov, 11:02 PM Test Summary: 56802 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16598

  18. Łukasz Uznański voted on patch set 8 CR +1 11/27/17, 15:12

  19. Tomas Norre Mikkelsen voted on patch set 8 CR +1 11/29/17, 09:01

  20. Benni Mack voted on patch set 8 CR +2 V +1 11/29/17, 18:11

  21. Susi Moog voted on patch set 8 V +2 11/29/17, 18:37

  22. Gerrit merged patch set 8 11/29/17, 18:37

  23. Stephan Großberndt commented on patch set 9 12/20/17, 16:43

    Backport to 8.7 is missing
  24. Stephan Großberndt commented on patch set 9 02/19/18, 20:52

    ping
  25. Benni Mack commented on patch set 9 02/20/18, 07:38

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a691a7f3587f91a4de881671c5d995075d610b9c