Review main Merged

4956[BUGFIX] Check curl availability before using it

Tolleiv Nietsch CR +2 V +2 Easy +1 −2 updated 06/03/13, 20:49

Commit message

Curl is used when activated in the install tool.
The core should check if curl is available before using it.

Because the getUrl() refactoring will hopefully be ready in 4.7,
I found that this simple solution should at least fix it for 4.6.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1
  • Verified V +2
    • Jigal van Hemert +2
    • Xavier Perseguers +1

Issues 1

Files 1

Review log 5

  1. Xavier Perseguers commented on patch set 1 09/16/11, 11:32

    Verified; Looks good to me, but someone else must approve
  2. Georg Ringer commented on patch set 1 09/16/11, 11:32

    IMO there should be at least a log or better an exception if curl is activated but not available!
  3. Jigal van Hemert commented on patch set 1 V 0 09/16/11, 11:32

    by team member; Looks good to me, approved Nice to prevent a PHP error in these cases. The handling of the error is similar to the rest of the function. Good catch!
  4. Mr. Jenkins commented on patch set 1 09/16/11, 11:32

  5. Jigal van Hemert merged patch set 1 09/16/11, 11:32