Review main Merged

49565[TASK] Prevent console warning in jsfunc.evalfield.js

Wouter Wolters CR +2 V +2 Easy +0 −1 updated 08/24/16, 05:09

Commit message

Remove the unreachable code to prevent a warning on the console.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Wouter Wolters uploaded patch set 1 08/23/16, 20:14

  2. TYPO3com voted on patch set 1 V +1 08/23/16, 20:16 Completed build in 02m 28s on Tue, 23 Aug, 10:16 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2282

  3. Christian Kuhn commented on patch set 1 08/23/16, 20:40

    jsfunc.evalfield.js:263

    please just remove that line. unreachable code is good for nothing.
  4. Christian Kuhn uploaded patch set 2 08/23/16, 20:40

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/23/16, 20:41

  6. Wouter Wolters updated the commit message in patch set 3 08/23/16, 20:43

  7. TYPO3com voted on patch set 2 V +1 08/23/16, 20:44 Completed build in 03m 51s on Tue, 23 Aug, 10:44 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2283

  8. TYPO3com voted on patch set 3 V +1 08/23/16, 20:45 Completed build in 02m 51s on Tue, 23 Aug, 10:45 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2284

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 08/23/16, 20:55

  10. Georg Ringer voted on patch set 3 CR +2 V +2 08/24/16, 05:08

  11. Gerrit merged patch set 3 08/24/16, 05:08

  12. Georg Ringer commented on patch set 4 08/24/16, 05:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f2b06f6f1be298d3d86da1799ba41af7d39b6039