49610[FEATURE] Make sys_language records sortable.
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Philipp Gampe +1
-
Verified V +2
- Andreas Wolf +2
- Philipp Gampe +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php+1 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −2
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseSystemLanguageRows.php+1 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php+5 −0
- typo3/sysext/beuser/Classes/ViewHelpers/Display/SysLanguageViewHelper.php+1 −1
- typo3/sysext/core/Configuration/TCA/sys_language.php+2 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-77652-MakeSys_languageRecordsSortable.rstnew+14 −0
- typo3/sysext/core/ext_tables.sql+1 −0
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+2 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −1
Review log 1014
-
Georg Ringer uploaded patch set 1 08/29/16, 07:03
-
TYPO3com voted on patch set 1 V -1 08/29/16, 07:06 Completed build in 02m 41s on Mon, 29 Aug, 09:06 AM Test Summary: 10 of 18646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2378
-
Georg Ringer uploaded patch set 2 08/29/16, 07:58
-
TYPO3com voted on patch set 2 V +1 08/29/16, 08:01 Completed build in 03m 06s on Mon, 29 Aug, 10:01 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2382
-
Stefan Neufeind commented on patch set 2 V +1 08/29/16, 15:15
How about the language-sorting in typo3/sysext/beuser/Classes/ViewHelpers/Display/SysLanguageViewHelper.php as well maybe? Rest looks fine to me. -
Georg Ringer uploaded patch set 3 08/31/16, 12:19
-
TYPO3com voted on patch set 3 V +1 08/31/16, 12:22 Completed build in 02m 47s on Wed, 31 Aug, 02:22 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2524
-
Daniel Windloff commented on patch set 3 08/31/16, 13:05
Hi, I have two more suggestions: TYPO3\CMS\Viewpage\Controller\ViewModuleController->getPreviewLanguages and TYPO3\CMS\Frontend\Controller\TranslationStatusController->getSystemLanguages -
Stefan Neufeind uploaded patch set 4 08/31/16, 15:28
-
Stefan Neufeind commented on patch set 3 08/31/16, 15:28
added the two other orderBy. Imho needs to be tested whether orderBy works fine with the groupBy in one case. -
TYPO3com voted on patch set 4 V +1 08/31/16, 15:31 Completed build in 02m 45s on Wed, 31 Aug, 05:31 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2535
-
Philipp Gampe voted on patch set 4 CR +1 V +1 09/01/16, 10:17
-
Andreas Wolf voted on patch set 4 CR +2 V +2 09/01/16, 11:19
-
Gerrit merged patch set 4 09/01/16, 11:19