Review main Merged

49611[TASK] Fix deprecated code calling LanguageService::sL()

Georg Ringer CR +2 V +2 Easy +17 −21 updated 08/29/16, 12:44

Commit message

Calling LanguageService::sL() with true for 2nd argument is deprecated.
Use htmlspecialchars() directly.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1012

  1. Georg Ringer uploaded patch set 1 08/29/16, 07:22

  2. Benni Mack voted on patch set 1 CR +1 V +1 08/29/16, 07:25

  3. TYPO3com voted on patch set 1 V +1 08/29/16, 07:25 Completed build in 02m 40s on Mon, 29 Aug, 09:25 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2380

  4. Stefan Neufeind commented on patch set 1 CR -1 08/29/16, 07:39

    some other places as well. I will take a look
  5. Stefan Neufeind uploaded patch set 2 08/29/16, 07:56

  6. Stefan Neufeind commented on patch set 2 08/29/16, 07:57

    I hope it's fine with you to turn this a bit more generic. There are just a few tiny places still calling sL() the old way.
  7. TYPO3com voted on patch set 2 V +1 08/29/16, 07:59 Completed build in 02m 28s on Mon, 29 Aug, 09:59 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2381

  8. Georg Ringer voted on patch set 2 CR +1 V +1 08/29/16, 08:01

  9. Benni Mack voted on patch set 2 CR +2 08/29/16, 09:44

  10. Wouter Wolters voted on patch set 2 CR +1 08/29/16, 10:23

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 08/29/16, 12:44

  12. Gerrit merged patch set 2 08/29/16, 12:44