Review main Merged

49639[FEATURE] Get flexform data in getText()

Georg Ringer CR +2 V +2 Easy +41 −0 updated 08/31/16, 11:46

Commit message

It is now possible to access the content of a flexform property
in TypoScript.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Georg Ringer uploaded patch set 1 08/30/16, 07:46

  2. TYPO3com voted on patch set 1 V +1 08/30/16, 07:49 Completed build in 02m 57s on Tue, 30 Aug, 09:49 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2420

  3. Mathias Brodala commented on patch set 1 08/30/16, 07:53

    Feature-17309-AccessFlexformValueViaTS.rst:23

    How about making this a ":" too to stay in line with other similar options like "DB" and "file"? The only options which use "," are slide-ish and with these it makes sense since you can set a list of fields. Here only a single field makes sense.
  4. Georg Ringer uploaded patch set 2 08/30/16, 22:51

  5. TYPO3com voted on patch set 2 V +1 08/30/16, 22:54 Completed build in 02m 36s on Wed, 31 Aug, 12:54 AM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2494

  6. Andreas Kienast voted on patch set 2 CR +1 08/31/16, 06:41

  7. Mathias Brodala voted on patch set 2 CR +1 08/31/16, 07:15

  8. Stefan Neufeind voted on patch set 2 CR +1 V +1 08/31/16, 08:14

  9. Jigal van Hemert commented on patch set 2 CR +1 08/31/16, 11:15

    Testing it now...
  10. Jigal van Hemert commented on patch set 2 CR +2 V +2 08/31/16, 11:46

    Works great with scalar values (string, number).
  11. Gerrit merged patch set 2 08/31/16, 11:46