Review main Merged

49642[FEATURE] Add argument addQueryStringMethod to f:form

Claus Due CR +2 V +2 Easy +21 −1 updated 10/09/16, 11:44

Commit message

The argument is passed to UriBuilder as-is and allows controlling
how the preserving of GET/POST arguments happens in f:form's
action URI generating method.

Review

  • Code review CR +2
    • Jan Helke +2
    • Daniel Windloff +1
    • Anja Leichsenring +1
    • Michał Jankiewicz +1
  • Verified V +2
    • Jan Helke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1418

  1. Claus Due uploaded patch set 1 08/30/16, 09:34

  2. Claus Due commented on patch set 1 08/30/16, 09:35

    This patch *also* makes a 790-char line into a 824-char line. We really, really should reformat this...
  3. TYPO3com voted on patch set 1 V +1 08/30/16, 09:37 Completed build in 03m 21s on Tue, 30 Aug, 11:37 AM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2427

  4. Karol Lamparski uploaded patch set 2 10/08/16, 08:22

  5. TYPO3com voted on patch set 2 V +1 10/08/16, 08:26 Completed build in 03m 13s on Sat, 8 Oct, 10:26 AM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3432

  6. Tomasz Stępniak voted on patch set 2 V +1 10/08/16, 11:14

  7. Daniel Windloff commented on patch set 2 10/08/16, 11:21

    FormViewHelper.php:125

    Should be string.
  8. Karol Lamparski commented on patch set 3 10/08/16, 11:34

    Published edit on patch set 2.
  9. TYPO3com voted on patch set 3 V +1 10/08/16, 11:37 Completed build in 03m 42s on Sat, 8 Oct, 01:37 PM Test Summary: 18549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3456

  10. Michał Jankiewicz uploaded patch set 4 10/08/16, 12:17

  11. Michał Jankiewicz voted on patch set 4 CR +1 10/08/16, 12:18

  12. TYPO3com voted on patch set 4 V +1 10/08/16, 12:21 Completed build in 03m 21s on Sat, 8 Oct, 02:21 PM Test Summary: 18549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3460

  13. Daniel Windloff voted on patch set 4 CR +1 10/08/16, 12:22

  14. Jan Helke voted on patch set 4 CR +1 10/08/16, 13:13

  15. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/09/16, 09:37

  16. Jan Helke voted on patch set 4 V +1 10/09/16, 11:44

  17. Jan Helke voted on patch set 4 CR +2 V +2 10/09/16, 11:44

  18. Gerrit merged patch set 4 10/09/16, 11:44