Review main Merged

49644[TASK] Streamline tbe_editor code

Benni Mack CR +2 V +2 Normal +33 −166 updated 09/07/16, 14:37

Commit message

- Use proper JS language functionality,
- Remove unused lines
- Set formname to "editform" by default

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1114

  1. Benni Mack uploaded patch set 1 08/30/16, 11:26

  2. TYPO3com voted on patch set 1 V -1 08/30/16, 11:28 Completed build in 02m 47s on Tue, 30 Aug, 01:28 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2432

  3. Benni Mack uploaded patch set 2 09/02/16, 09:19

  4. TYPO3com voted on patch set 2 V +1 09/02/16, 09:22 Completed build in 02m 54s on Fri, 2 Sep, 11:22 AM Test Summary: 18496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2713

  5. Frank Nägler commented on patch set 2 CR +1 09/02/16, 12:37

    looks good, will test it later
  6. Andreas Kienast voted on patch set 2 CR +1 V +1 09/03/16, 08:33

  7. Wouter Wolters voted on patch set 2 CR +1 09/03/16, 09:31

  8. Wouter Wolters commented on patch set 2 CR -1 09/03/16, 13:29

    passwordDummy is still set in EditDocumentController.
  9. Wouter Wolters uploaded patch set 3 09/03/16, 13:30

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 09/03/16, 13:30

  11. TYPO3com voted on patch set 3 V +1 09/03/16, 13:33 Completed build in 03m 03s on Sat, 3 Sep, 03:33 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2894

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 09/03/16, 14:41

  13. Gerrit merged patch set 3 09/03/16, 14:41

  14. Daniel Goerz commented on patch set 4 09/07/16, 14:37