49665[TASK] Add more fixers for php-cs-fixer
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Georg Ringer +1
-
Verified V +2
- Andreas Kienast +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 172
- Build/.php_cs+12 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+3 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+7 −7
- typo3/sysext/backend/Classes/History/RecordHistory.php+1 −1
- typo3/sysext/backend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/HelpButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/Action/ShortcutButton.php+2 −2
- typo3/sysext/backend/Classes/Template/Components/Buttons/FullyRenderedButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/Menu/Menu.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/ExtdirectTreeCommands.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/PagetreeNode.php+12 −12
- typo3/sysext/backend/Classes/Tree/Renderer/ExtJsJsonTreeRenderer.php+2 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −5
- typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php+1 −1
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −2
Show 152 more files
- typo3/sysext/backend/Tests/Unit/Form/Element/InputTextElementTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessRecordTitleTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+1 −1
- typo3/sysext/core/Build/Configuration/Acceptance/Support/AcceptanceTester.php+1 −1
- typo3/sysext/core/Build/Scripts/cglFixMyCommit.sh+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+32 −32
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+1 −1
- typo3/sysext/core/Classes/Category/Collection/CategoryCollection.php+2 −2
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+1 −1
- typo3/sysext/core/Classes/Collection/StaticRecordCollection.php+1 −1
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+1 −1
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+1 −1
- typo3/sysext/core/Classes/Core/ApplicationContext.php+4 −4
- typo3/sysext/core/Classes/Crypto/Random.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Expression/CompositeExpression.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/AbstractRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/BackendWorkspaceRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/DeletedRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/EndTimeRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendGroupRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/HiddenRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/QueryRestrictionContainerInterface.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/QueryRestrictionInterface.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/RootLevelRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/StartTimeRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/BulkInsertQuery.php+1 −1
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+2 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −1
- typo3/sysext/core/Classes/Database/Connection.php+1 −1
- typo3/sysext/core/Classes/Database/ConnectionPool.php+2 −2
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+5 −5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+2 −2
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+1 −1
- typo3/sysext/core/Classes/Html/HtmlParser.php+1 −1
- typo3/sysext/core/Classes/Http/Stream.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+2 −2
- typo3/sysext/core/Classes/Imaging/IconFactory.php2+3 −3
- typo3/sysext/core/Classes/LinkHandling/EmailLinkHandler.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/FileLinkHandler.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/FolderLinkHandler.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LinkHandlingInterface.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+1 −2
- typo3/sysext/core/Classes/LinkHandling/PageLinkHandler.php+1 −1
- typo3/sysext/core/Classes/Localization/Locales.php+1 −1
- typo3/sysext/core/Classes/Locking/SemaphoreLockStrategy.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+5 −5
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+5 −5
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/Rendering/RendererRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+26 −26
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+2 −2
- typo3/sysext/core/Classes/Type/Bitmask/JsConfirmation.php+1 −1
- typo3/sysext/core/Classes/Utility/ClientUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+3 −3
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −2
- typo3/sysext/core/Resources/PHP/RemoveXSS.php+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/GetUniqueTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SpecialLanguagesTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/CheckValueTestForCheckboxes.php+1 −1
- typo3/sysext/core/Tests/Functional/Framework/Frontend/Collector.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Crypto/RandomTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DefaultRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DeletedRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/EndTimeRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendGroupRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/HiddenRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/RootLevelRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/StartTimeRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/QueryHelperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/ConnectionPoolTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Locking/FileLockStrategyTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php2+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/Fixtures/TreeDataProviderWithConfigurationFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+0 −1
- typo3/sysext/documentation/Classes/Slots/ExtensionManager.php+2 −1
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/extbase/Classes/Error/Result.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/FloatConverter.php+2 −2
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassReflection.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/OperatorTest.php+3 −1
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+12 −4
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/Fixtures/DateTimeSubFixture.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/SignalSlot/DispatcherTest.php+10 −5
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+1 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+4 −5
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Security/IfAuthenticatedViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/AbstractBackendViewHelper.php+6 −6
- typo3/sysext/fluid/Classes/ViewHelpers/SwitchViewHelper.php+3 −3
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/Fixtures/ClassWithTwoGetters.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+1 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+1 −1
- typo3/sysext/fluid_styled_content/Configuration/TCA/Overrides/tt_content.php+0 −1
- typo3/sysext/form/Classes/Domain/Builder/ElementBuilder.php+3 −3
- typo3/sysext/form/Classes/Domain/Builder/FormBuilder.php+1 −1
- typo3/sysext/form/Classes/Domain/Builder/ValidationBuilder.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/Configuration.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/ValidationElement.php+2 −2
- typo3/sysext/form/Classes/Domain/Validator/RequiredValidator.php+4 −4
- typo3/sysext/form/Classes/Mvc/Controller/ControllerContext.php+1 −1
- typo3/sysext/form/Classes/Utility/FormUtility.php+4 −4
- typo3/sysext/form/Tests/Unit/Validator/BetweenValidatorTest.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageRepository.php+2 −2
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+3 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+4 −4
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php+97 −97
- typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php+1 −1
- typo3/sysext/install/Classes/FolderStructure/FileNode.php+1 −1
- typo3/sysext/install/Classes/Service/ContextService.php+1 −1
- typo3/sysext/install/Classes/Service/EnableFileService.php+1 −1
- typo3/sysext/install/Classes/Service/SessionService.php+1 −1
- typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php+3 −1
- typo3/sysext/lang/Classes/Service/RegistryService.php+1 −1
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList.php+1 −1
- typo3/sysext/rsaauth/Classes/RsaAuthService.php+2 −2
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionTask.php+5 −5
- typo3/sysext/sv/Classes/AuthenticationService.php+3 −3
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/StageRecord.php+14 −14
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/StagesService.php+3 −1
Review log 912
-
Wouter Wolters uploaded patch set 1 08/30/16, 20:17
-
TYPO3com voted on patch set 1 V -1 08/30/16, 20:19 Completed build in 02m 40s on Tue, 30 Aug, 10:19 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2477
-
Wouter Wolters uploaded patch set 2 08/30/16, 20:28
-
Wouter Wolters commented on patch set 2 CR -1 08/30/16, 20:31
still on it -
TYPO3com voted on patch set 2 V +1 08/30/16, 20:31 Completed build in 02m 40s on Tue, 30 Aug, 10:31 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2479
-
Wouter Wolters uploaded patch set 3 08/30/16, 20:38
-
TYPO3com voted on patch set 3 V +1 08/30/16, 20:42 Completed build in 03m 41s on Tue, 30 Aug, 10:42 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2480
-
Georg Ringer voted on patch set 3 CR +1 V +1 08/30/16, 20:45
-
Andreas Kienast voted on patch set 3 CR +2 V +2 08/30/16, 21:09
-
Gerrit merged patch set 3 08/30/16, 21:09
-
Christian Kuhn commented on patch set 3 08/30/16, 21:13
BackendUserAuthentication.php:2660does that really work?DataHandler.php:8465does it work?IconFactory.php:325to test ;)ResourceCompressorTest.php:370maybe switch that to a normal // comment only and remove the /* ? -
Wouter Wolters commented on patch set 3 08/30/16, 21:20
BackendUserAuthentication.php:2660ReplyyesDataHandler.php:8465ReplyyesIconFactory.php:325ReplyworksResourceCompressorTest.php:370ReplyAgree but this is not a priority change IMO