Review main Merged

49665[TASK] Add more fixers for php-cs-fixer

Wouter Wolters CR +2 V +2 Hard +481 −452 updated 08/30/16, 21:20

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 172

Show 152 more files

Review log 912

  1. Wouter Wolters uploaded patch set 1 08/30/16, 20:17

  2. TYPO3com voted on patch set 1 V -1 08/30/16, 20:19 Completed build in 02m 40s on Tue, 30 Aug, 10:19 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2477

  3. Wouter Wolters uploaded patch set 2 08/30/16, 20:28

  4. Wouter Wolters commented on patch set 2 CR -1 08/30/16, 20:31

    still on it
  5. TYPO3com voted on patch set 2 V +1 08/30/16, 20:31 Completed build in 02m 40s on Tue, 30 Aug, 10:31 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2479

  6. Wouter Wolters uploaded patch set 3 08/30/16, 20:38

  7. TYPO3com voted on patch set 3 V +1 08/30/16, 20:42 Completed build in 03m 41s on Tue, 30 Aug, 10:42 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2480

  8. Georg Ringer voted on patch set 3 CR +1 V +1 08/30/16, 20:45

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 08/30/16, 21:09

  10. Gerrit merged patch set 3 08/30/16, 21:09

  11. Christian Kuhn commented on patch set 3 08/30/16, 21:13

    BackendUserAuthentication.php:2660

    does that really work?

    DataHandler.php:8465

    does it work?

    IconFactory.php:325

    to test ;)

    ResourceCompressorTest.php:370

    maybe switch that to a normal // comment only and remove the /* ?
  12. Wouter Wolters commented on patch set 3 08/30/16, 21:20

    BackendUserAuthentication.php:2660 Reply

    yes

    DataHandler.php:8465 Reply

    yes

    IconFactory.php:325 Reply

    works

    ResourceCompressorTest.php:370 Reply

    Agree but this is not a priority change IMO