Review main Merged

49666[TASK] Merge indexed_search_mysql

Christian Kuhn CR +2 V +2 Hard +536 −270 updated 09/01/16, 07:51

Commit message

* Merge hook from indexed_search_mysql directly into indexed_search
  and compatibilty7
* Migrate "hook code" merged into indexed_search to doctrine
* Add a feature flag in ext_conf_template "useMysqlFulltext"
* Add a hook to schema migrator if feature flag is enabled to
  register fulltext indexes

Review

  • Code review CR +2
    • Georg Ringer +2
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Morton Jonuschat +1

Issues 1

Files 15

Review log 1522

  1. Christian Kuhn uploaded patch set 1 08/30/16, 20:23

  2. Christian Kuhn commented on patch set 1 CR -2 08/30/16, 20:24

    still wip, several things missing
  3. TYPO3com voted on patch set 1 V -1 08/30/16, 20:26 Completed build in 02m 29s on Tue, 30 Aug, 10:26 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2478

  4. Benni Mack commented on patch set 1 08/31/16, 09:46

    I would actually do the renaming separately (as you'd need some Class alias things then as well)
  5. Christian Kuhn commented on patch set 1 08/31/16, 10:22

    yeah benni, came to the same solution, will do the extension renaming in a separate patch.
  6. Christian Kuhn uploaded patch set 2 08/31/16, 14:01

  7. TYPO3com voted on patch set 2 V +1 08/31/16, 14:05 Completed build in 03m 13s on Wed, 31 Aug, 04:05 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2527

  8. Christian Kuhn uploaded patch set 3 08/31/16, 14:46

  9. TYPO3com voted on patch set 3 V +1 08/31/16, 14:50 Completed build in 03m 18s on Wed, 31 Aug, 04:50 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2528

  10. Christian Kuhn uploaded patch set 4 08/31/16, 15:32

  11. TYPO3com voted on patch set 4 V -1 08/31/16, 15:33 Completed build in 29s on Wed, 31 Aug, 05:33 PM Test Summary: 62 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2538

  12. Christian Kuhn uploaded patch set 5 08/31/16, 15:39

  13. TYPO3com voted on patch set 5 V +1 08/31/16, 15:41 Completed build in 02m 33s on Wed, 31 Aug, 05:41 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2540

  14. Christian Kuhn uploaded patch set 6 08/31/16, 16:02

  15. Christian Kuhn commented on patch set 6 CR -1 08/31/16, 16:03

    starting testing now. hint: we may add an upgrade wizard later to further lift the impact of this change.
  16. TYPO3com voted on patch set 6 V +1 08/31/16, 16:05 Completed build in 02m 42s on Wed, 31 Aug, 06:05 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2543

  17. Morton Jonuschat uploaded patch set 7 08/31/16, 16:25

  18. Morton Jonuschat voted on patch set 7 CR +1 V +1 08/31/16, 16:25

  19. Georg Ringer voted on patch set 7 CR +2 V +2 08/31/16, 16:27

  20. Gerrit merged patch set 7 08/31/16, 16:28

  21. TYPO3com commented on patch set 7 08/31/16, 16:28 Completed build in 02m 45s on Wed, 31 Aug, 06:28 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2546

  22. Nicole Hummel commented on patch set 8 09/01/16, 07:51

    Post -1 due to missing composer.lock update.