49666[TASK] Merge indexed_search_mysql
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Morton Jonuschat +1
-
Verified V +2
- Georg Ringer +2
- Morton Jonuschat +1
Issues 1
Files 15
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+176 −0
- typo3/sysext/compatibility7/ext_emconf.php+2 −3
- typo3/sysext/core/Documentation/Changelog/master/Breaking-77700-ExtensionIndexed_search_mysqlMergedIntoIndexed_search.rstnew+31 −0
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+244 −1
- typo3/sysext/indexed_search/Classes/Service/DatabaseSchemaService.phpnew+51 −0
- typo3/sysext/indexed_search/Resources/Private/Language/locallang_em.xlf+3 −0
- typo3/sysext/indexed_search/ext_conf_template.txt+3 −0
- typo3/sysext/indexed_search/ext_localconf.php+26 −2
- typo3/sysext/indexed_search_mysql/Classes/Hook/MysqlFulltextIndexHook.phpdeleted+0 −199
- typo3/sysext/indexed_search_mysql/composer.jsondeleted+0 −19
- typo3/sysext/indexed_search_mysql/ext_emconf.phpdeleted+0 −22
- typo3/sysext/indexed_search_mysql/ext_icon.pngdeletedbinary
- typo3/sysext/indexed_search_mysql/ext_localconf.phpdeleted+0 −7
- typo3/sysext/indexed_search_mysql/ext_tables.sqldeleted+0 −16
- composer.json+0 −1
Review log 1522
-
Christian Kuhn uploaded patch set 1 08/30/16, 20:23
-
Christian Kuhn commented on patch set 1 CR -2 08/30/16, 20:24
still wip, several things missing -
TYPO3com voted on patch set 1 V -1 08/30/16, 20:26 Completed build in 02m 29s on Tue, 30 Aug, 10:26 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2478
-
Benni Mack commented on patch set 1 08/31/16, 09:46
I would actually do the renaming separately (as you'd need some Class alias things then as well) -
Christian Kuhn commented on patch set 1 08/31/16, 10:22
yeah benni, came to the same solution, will do the extension renaming in a separate patch. -
Christian Kuhn uploaded patch set 2 08/31/16, 14:01
-
TYPO3com voted on patch set 2 V +1 08/31/16, 14:05 Completed build in 03m 13s on Wed, 31 Aug, 04:05 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2527
-
Christian Kuhn uploaded patch set 3 08/31/16, 14:46
-
TYPO3com voted on patch set 3 V +1 08/31/16, 14:50 Completed build in 03m 18s on Wed, 31 Aug, 04:50 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2528
-
Christian Kuhn uploaded patch set 4 08/31/16, 15:32
-
TYPO3com voted on patch set 4 V -1 08/31/16, 15:33 Completed build in 29s on Wed, 31 Aug, 05:33 PM Test Summary: 62 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2538
-
Christian Kuhn uploaded patch set 5 08/31/16, 15:39
-
TYPO3com voted on patch set 5 V +1 08/31/16, 15:41 Completed build in 02m 33s on Wed, 31 Aug, 05:41 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2540
-
Christian Kuhn uploaded patch set 6 08/31/16, 16:02
-
Christian Kuhn commented on patch set 6 CR -1 08/31/16, 16:03
starting testing now. hint: we may add an upgrade wizard later to further lift the impact of this change. -
TYPO3com voted on patch set 6 V +1 08/31/16, 16:05 Completed build in 02m 42s on Wed, 31 Aug, 06:05 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2543
-
Morton Jonuschat uploaded patch set 7 08/31/16, 16:25
-
Morton Jonuschat voted on patch set 7 CR +1 V +1 08/31/16, 16:25
-
Georg Ringer voted on patch set 7 CR +2 V +2 08/31/16, 16:27
-
Gerrit merged patch set 7 08/31/16, 16:28
-
TYPO3com commented on patch set 7 08/31/16, 16:28 Completed build in 02m 45s on Wed, 31 Aug, 06:28 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2546
-
Nicole Hummel commented on patch set 8 09/01/16, 07:51
Post -1 due to missing composer.lock update.