Review main Merged

49667[BUGFIX] Highlight keywords containing utf-8 characters in pagetree search

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 08/31/16, 15:09

Commit message

Adds a 'u' switch to preg_replace

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Philipp Gampe +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Stefan Neufeind +2
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Tymoteusz Motylewski uploaded patch set 1 08/30/16, 20:59

  2. Wouter Wolters voted on patch set 1 CR +1 08/30/16, 20:59

  3. TYPO3com voted on patch set 1 V +1 08/30/16, 21:01 Completed build in 02m 39s on Tue, 30 Aug, 11:01 PM Test Summary: 18646 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2484

  4. Andreas Kienast voted on patch set 1 CR +1 08/30/16, 21:04

  5. Stefan Neufeind commented on patch set 1 CR +1 08/31/16, 00:12

    fine by reading, if you say it fixes something. but works for me locally even without the patch (master, php 7.0.9, mariadb with utf8_general_ci)
  6. Tymoteusz Motylewski commented on patch set 1 08/31/16, 14:21

    @Stefan, has you tried the exact example described in the ticket? I mean page title with uppercase umlaut and sear term with lowercase?
  7. Tymoteusz Motylewski commented on patch set 1 08/31/16, 14:23

    I'm on PHP 7.0.9-1+deb.sury.org~trusty+1
  8. Philipp Gampe voted on patch set 1 CR +2 V +1 08/31/16, 14:57

  9. Stefan Neufeind commented on patch set 1 V -1 08/31/16, 15:08

    will verify ... just a sec
  10. Stefan Neufeind voted on patch set 1 CR +2 V +2 08/31/16, 15:09

  11. Gerrit merged patch set 1 08/31/16, 15:09

  12. Stefan Neufeind commented on patch set 2 08/31/16, 15:09

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0a85e9c38a8b89d0686a56d6b91439a9f2c1956a