Review main Merged

49672[FOLLOWUP][FEATURE] Allow EXT: syntax in PageRenderer and Compressor

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 08/31/16, 09:25

Commit message

The stylesheet files are included now by the PageRenderer to convert the
EXT: prefix into a real path, avoiding ERR_UNKNOWN_URL_SCHEME errors.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 08/31/16, 07:40

  2. TYPO3com voted on patch set 1 V +1 08/31/16, 07:43 Completed build in 02m 34s on Wed, 31 Aug, 09:43 AM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2500

  3. Andreas Kienast commented on patch set 1 08/31/16, 07:44

    Please test this really carefully as I currently can't overview the implications by returning an empty string now.
  4. Andreas Kienast uploaded patch set 2 08/31/16, 07:47

  5. Wouter Wolters voted on patch set 2 CR +1 08/31/16, 07:48

  6. TYPO3com voted on patch set 2 V +1 08/31/16, 07:51 Completed build in 03m 45s on Wed, 31 Aug, 09:51 AM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2501

  7. Stefan Neufeind voted on patch set 2 CR +1 08/31/16, 07:59

  8. Benni Mack voted on patch set 2 CR +2 V +2 08/31/16, 09:25

  9. Gerrit merged patch set 2 08/31/16, 09:25