Review TYPO3_7-6 Merged

49675[BUGFIX] Fix syntax errors in ext_tables.sql files

Morton Jonuschat CR +2 V +2 Easy +6 −6 updated 08/31/16, 08:27

Commit message

Fix syntax errors by removing commas in excess after the last column/
key definition, add commas missing after column/key definitions and
removing default values for auto_increment columns.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 79

  1. Morton Jonuschat uploaded patch set 1 08/31/16, 08:04

  2. TYPO3com voted on patch set 1 V -1 08/31/16, 08:05 Completed build in 32s on Wed, 31 Aug, 10:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-51

  3. Morton Jonuschat uploaded patch set 2 08/31/16, 08:08

  4. TYPO3com voted on patch set 2 V +1 08/31/16, 08:11 Completed build in 02m 25s on Wed, 31 Aug, 10:11 AM Test Summary: 34906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-52

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 08/31/16, 08:14

  6. Wouter Wolters voted on patch set 2 CR +2 V +2 08/31/16, 08:22

  7. Gerrit merged patch set 2 08/31/16, 08:22

  8. Stefan Neufeind commented on patch set 2 08/31/16, 08:26

    briefly checked sql-files by reading; used install-tool to make sure it worked fine and showed no difference for db-compare before/after this patch
  9. Stefan Neufeind commented on patch set 3 08/31/16, 08:27

    post +1 verified