49677[TASK] Use strpos instead of substr to check the start of a string
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Stefan Neufeind +1
- Sascha Egerer +1
- Andreas Kienast +1
-
Verified V +2
- Philipp Gampe +2
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php+2 −2
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/AccessibilityLinkController.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/RteHtmlAreaApi.php+1 −1
Review log 1012
-
Wouter Wolters uploaded patch set 1 08/31/16, 10:59
-
TYPO3com voted on patch set 1 V +1 08/31/16, 11:02 Completed build in 02m 37s on Wed, 31 Aug, 01:02 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2514
-
Wouter Wolters updated the commit message in patch set 2 09/01/16, 13:50
-
TYPO3com voted on patch set 2 V +1 09/01/16, 13:53 Completed build in 02m 47s on Thu, 1 Sep, 03:53 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2638
-
Sascha Egerer commented on patch set 2 CR -1 09/01/16, 14:19
There are some more places like typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php:230 Should also be fixed, right? -
Wouter Wolters commented on patch set 2 09/01/16, 14:23
Sascha: There are many more occurences these fix the EXT: check. And maybe a few others that were in the same spot. We could mark this as part 1. -
Sascha Egerer voted on patch set 2 CR +1 09/01/16, 14:40
-
Philipp Gampe voted on patch set 2 CR +1 09/01/16, 14:46
-
Stefan Neufeind commented on patch set 2 CR +1 09/01/16, 16:03
I'm fine to have it as "part 1" or whatever in the commit-msg. I expect it was agreed to have this optimization / have it as a general rule to do it that way? -
Andreas Kienast voted on patch set 2 CR +1 09/01/16, 17:00
-
Philipp Gampe voted on patch set 2 CR +2 V +2 09/01/16, 18:11
-
Gerrit merged patch set 2 09/01/16, 18:11