Review main Merged

49684[BUGFIX] Initialize selectTree in inline relations

Tymoteusz Motylewski CR +2 V +2 Easy +20 −8 updated 09/03/16, 22:43

Commit message

Adds a callback function when requiring the SelectTreeElement module,
so initialization is triggered every time it's required.

Adds check whether component was initialized to prevent
double initialization.

Fix variable name typo $overlayIcon to $overlayIconMarkup

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Alexander Stehlik +1
    • Markus Gehrig +1
  • Verified V +2
    • Benni Mack +2
    • Lukas Raschke +1
    • Alexander Stehlik +1

Issues 1

Files 5

Review log 1518

  1. Tymoteusz Motylewski uploaded patch set 1 08/31/16, 15:02

  2. TYPO3com voted on patch set 1 V +1 08/31/16, 15:05 Completed build in 02m 43s on Wed, 31 Aug, 05:05 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2529

  3. Stefan Neufeind commented on patch set 1 08/31/16, 15:42

    Could it be that the related category field is already available in master withut this patch? Also for 7.6 and 6.2 possible or too invasive? The issue says it occured as a regression on 6.2 as well.
  4. Christian Kuhn commented on patch set 1 08/31/16, 16:19

    SelectTreeElement.php:110

    is there no way on js side to keep this requirejs call here and not hardcode it into formengine.js? - It would be much better if we don't need to hardwire those dependencies. maybe frank could give some hints here?
  5. Tymoteusz Motylewski commented on patch set 1 08/31/16, 16:20

    for v7 and v6 the fix is different, maybe even the patch attached to the issue is valid. haven't checked it. I can push it in the separate patch, so this one is not backported accidentaly :)
  6. Tymoteusz Motylewski commented on patch set 1 08/31/16, 16:22

    SelectTreeElement.php:110 Reply

    let's talk about it in person. I can imagine that formengine would trigger an event once it loads a ajax form, so js component can instantiate themselves. Or some other kind of api.
  7. Tymoteusz Motylewski commented on patch set 1 CR -1 08/31/16, 18:41

    will prepare a new patchset
  8. Tymoteusz Motylewski uploaded patch set 2 09/01/16, 10:28

  9. TYPO3com voted on patch set 2 V +1 09/01/16, 10:31 Completed build in 03m 10s on Thu, 1 Sep, 12:31 PM Test Summary: 19102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2618

  10. Tymoteusz Motylewski updated the commit message in patch set 3 09/02/16, 08:57

  11. TYPO3com voted on patch set 3 V +1 09/02/16, 09:00 Completed build in 02m 56s on Fri, 2 Sep, 11:00 AM Test Summary: 18496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2710

  12. Tymoteusz Motylewski uploaded patch set 4 09/02/16, 15:52

  13. Lukas Raschke voted on patch set 4 V +1 09/02/16, 20:28

  14. Markus Gehrig voted on patch set 4 CR +1 09/02/16, 21:04

  15. Wouter Wolters voted on patch set 4 CR +1 09/02/16, 22:33

  16. Alexander Stehlik voted on patch set 4 CR +1 V +1 09/03/16, 10:34

  17. Benni Mack voted on patch set 4 CR +2 V +2 09/03/16, 22:43

  18. Gerrit merged patch set 4 09/03/16, 22:43