Review main Merged

49696[TASK] Deprecate Extbase's ArrayUtility

Benni Mack CR +2 V +2 Expert +586 −474 updated 12/18/16, 10:44

Commit message

The copied methods from ArrayUtility can be removed
and be replaced with some PHP native functionality
or the equivalent functionality.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 22

Show 2 more files

Review log 4564

Show 2539 earlier messages
  1. Benni Mack uploaded patch set 1 08/31/16, 19:18

  2. TYPO3com voted on patch set 1 V -1 08/31/16, 19:22 Completed build in 04m 21s on Wed, 31 Aug, 09:22 PM Test Summary: 18650 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2555

  3. Georg Ringer uploaded patch set 2 09/01/16, 07:02

  4. TYPO3com voted on patch set 2 V +1 09/01/16, 07:04 Completed build in 02m 45s on Thu, 1 Sep, 09:04 AM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2575

  5. Georg Ringer uploaded patch set 3 09/01/16, 07:28

  6. Mathias Brodala commented on patch set 4 09/01/16, 07:30

    Published edit on patch set 3.
  7. TYPO3com voted on patch set 3 V +1 09/01/16, 07:31 Completed build in 02m 50s on Thu, 1 Sep, 09:31 AM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2576

  8. TYPO3com voted on patch set 4 V +1 09/01/16, 07:33 Completed build in 02m 44s on Thu, 1 Sep, 09:33 AM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2577

  9. Andreas Kienast voted on patch set 4 CR +1 09/01/16, 07:35

  10. Mathias Brodala commented on patch set 4 09/01/16, 07:35

    A few ideas/questions to really deprecate the whole class.

    ArrayUtility.php:188

    I think this can be migrated too if the \RuntimException thrown by core ArrayUtility::getValueByPath() is caught.

    ArrayUtility.php:215

    This could be covered by the core ArrayUtility::setValueByPath() if we drop the type hint there and merge the two code blocks.

    ArrayUtility.php:345

    Can this be moved to the core ArrayUtility?
  11. Wouter Wolters commented on patch set 4 CR +1 V +1 09/28/16, 11:35

    IMHO we can get this in as first step. These are the rather easy deprecations.
  12. Markus Sommer voted on patch set 4 CR +1 V +1 09/30/16, 12:16

  13. Benni Mack commented on patch set 4 CR -2 10/08/16, 19:53

    I'd like to have one patch to deprecate the whole class. If anyone feels like taking over to migrate the other methods as mentioned in the main ArrayUtility class, go ahead and finish that one. I hope we get this finished rather sooner than later.
  14. Benni Mack uploaded patch set 5 10/15/16, 19:01

  15. TYPO3com voted on patch set 5 V -1 10/15/16, 19:07 Completed build in 05m 56s on Sat, 15 Oct, 09:07 PM Test Summary: 4 of 19558 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3791

  16. Benni Mack voted on patch set 5 CR 0 10/17/16, 10:06

  17. Benni Mack uploaded patch set 6 11/09/16, 21:10

  18. TYPO3com voted on patch set 6 V -1 11/09/16, 21:15 Completed build in 05m 24s on Wed, 9 Nov, 10:15 PM Test Summary: 55283 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4744

  19. Benni Mack uploaded patch set 7 11/10/16, 12:31

  20. TYPO3com voted on patch set 7 V -1 11/10/16, 13:04 Completed build in 27m 32s on Thu, 10 Nov, 02:04 PM Test Summary: 6 of 55283 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4770

  21. Markus Sommer uploaded patch set 8 12/03/16, 15:49

  22. Markus Sommer uploaded patch set 9 12/03/16, 15:51

  23. Markus Sommer commented on patch set 9 12/03/16, 15:52

    Core Reformat and remove new usages
  24. TYPO3com voted on patch set 8 V -1 12/03/16, 15:56 Completed build in 07m 08s on Sat, 3 Dec, 04:56 PM Test Summary: 54 of 54220 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5419

  25. TYPO3com voted on patch set 9 V -1 12/03/16, 15:58 Completed build in 06m 17s on Sat, 3 Dec, 04:58 PM Test Summary: 54 of 54220 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5420

  26. Markus Sommer commented on patch set 10 12/03/16, 16:08

    Published edit on patch set 9.
  27. TYPO3com voted on patch set 10 V -1 12/03/16, 16:15 Completed build in 06m 50s on Sat, 3 Dec, 05:15 PM Test Summary: 54 of 54310 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5428

  28. Susi Moog commented on patch set 10 CR -1 12/03/16, 18:09

    InheritanceResolverService: the functionality of getValueByPath of the core ArrayUtility is different to the one from extbase. First of all the array is not handled as reference, second the delimiter is different and has to be set in the call and last the core method throws an exception that has to be caught to simulate the old behaviour.
  29. Markus Sommer uploaded patch set 11 12/04/16, 10:39

  30. Markus Sommer commented on patch set 11 12/04/16, 10:41

    At the moment we can not replace the Extbase ArrayUtility in InheritanceResolverService.
  31. TYPO3com voted on patch set 11 V -1 12/04/16, 10:50 Completed build in 11m 16s on Sun, 4 Dec, 11:50 AM Test Summary: 54340 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5459

  32. Markus Sommer uploaded patch set 12 12/04/16, 10:58

  33. Markus Sommer uploaded patch set 13 12/04/16, 11:06

  34. TYPO3com voted on patch set 12 V -1 12/04/16, 11:31 Completed build in 33m 13s on Sun, 4 Dec, 12:31 PM Test Summary: 54340 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5480

  35. TYPO3com voted on patch set 13 V +1 12/04/16, 11:43 Completed build in 37m 22s on Sun, 4 Dec, 12:43 PM Test Summary: 54340 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5486

  36. Susi Moog commented on patch set 13 12/07/16, 11:11

    InheritancesResolverService.php:379

    the array is not used as reference, isn't it?
  37. Susi Moog commented on patch set 13 CR -1 12/08/16, 18:08

    on it
  38. Susi Moog uploaded patch set 14 12/08/16, 19:47

  39. TYPO3com voted on patch set 14 V -1 12/08/16, 19:51 Completed build in 04m 15s on Thu, 8 Dec, 08:51 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5616

  1. Christian Kuhn commented on patch set 14 12/08/16, 20:03

    minor comments, other than that reads good. Great to see we're down from 3 different ArrayUtility classes to 1.

    FormEditorController.php:77

    maybe change the use to ArrayUtility, too?

    FormManagerController.php:28

    srsly?

    ConfigurationManager.php:113

    mmmh. maybe think about that method, too? or do it later?
  2. Susi Moog uploaded patch set 15 12/09/16, 11:03

  3. Susi Moog commented on patch set 15 12/09/16, 11:06

    FormManagerController.php:28 Reply

    Done

    ConfigurationManager.php:113 Reply

    Done
  4. TYPO3com voted on patch set 15 V +1 12/09/16, 11:07 Completed build in 04m 03s on Fri, 9 Dec, 12:07 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5643

  5. Benni Mack commented on patch set 16 12/09/16, 11:39

    Published edit on patch set 15.
  6. Benni Mack commented on patch set 16 12/09/16, 11:41

    FormEditorController.php:129

    any chance we can use array_replace_recursive here as well?
  7. TYPO3com voted on patch set 16 V +1 12/09/16, 11:44 Completed build in 04m 31s on Fri, 9 Dec, 12:44 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5648

  8. Susi Moog uploaded patch set 17 12/10/16, 11:58

  9. TYPO3com voted on patch set 17 V +1 12/10/16, 12:02 Completed build in 03m 42s on Sat, 10 Dec, 01:02 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5675

  10. Benni Mack voted on patch set 17 CR +1 V +1 12/12/16, 07:27

  11. Wouter Wolters commented on patch set 17 CR -1 12/12/16, 21:15

    ArrayUtility.php:810

    empty line missing here

    ArrayUtility.php:818

    typehint array missing?

    AbstractRenderable.php:162

    is undefined
  12. Wouter Wolters uploaded patch set 18 12/12/16, 21:28

  13. TYPO3com voted on patch set 18 V +1 12/12/16, 21:31 Completed build in 03m 22s on Mon, 12 Dec, 10:31 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5715

  14. Wouter Wolters voted on patch set 18 CR +1 V +1 12/12/16, 21:33

  15. Christian Müllenhagen commented on patch set 18 12/12/16, 21:58

    ArrayUtility.php:819

    Here is the type missing.
  16. Benni Mack uploaded patch set 19 12/13/16, 05:37

  17. TYPO3com voted on patch set 19 V +1 12/13/16, 05:42 Completed build in 04m 34s on Tue, 13 Dec, 06:42 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5718

  18. Susi Moog voted on patch set 19 CR +1 V +1 12/13/16, 08:42

  19. Christian Kuhn voted on patch set 19 CR +2 V +2 12/13/16, 14:31

  20. Gerrit merged patch set 19 12/13/16, 14:31

  21. Oliver Hader commented on patch set 20 12/18/16, 10:09

    Regression for FormArrayUtility

    FormRuntime.php:38

    This was not replaces in the source - see https://forge.typo3.org/issues/79022

    YamlSource.php:25

    This was not replaces in the source - see https://forge.typo3.org/issues/79022
  22. Oliver Hader commented on patch set 20 12/18/16, 10:24

  23. Oliver Hader commented on patch set 20 12/18/16, 10:39

    There are more glitches - EXT:form currently does not render in the frontend. Basically the reason is the core's and Extbase's ArrayUtility::getValueByPath behave differently if an index is not set - the core variant throws an exception...
  24. Oliver Hader commented on patch set 20 12/18/16, 10:41

    And the core uses '/' as delimiter, Extbase uses implicitly a dot '.'
  25. Susi Moog commented on patch set 20 12/18/16, 10:44

    For the exception vs null at getValueByPath see https://review.typo3.org/#/c/49696/20/typo3/sysext/form/Classes/Mvc/Configuration/InheritancesResolverService.php << that should have beed done everywhere the non-exception behaviour is needed, same for the delimiter.