4971[TASK] Improve information in show_item.php
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Jigal van Hemert +2
- Philipp Gampe +1
-
Verified V +2
- Tolleiv Nietsch +2
- Jigal van Hemert +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 23
-
Georg Ringer commented on patch set 1 10/05/11, 14:31
Do not submitshow_item.php:430space instead of tabshow_item.php:431wouldnt that be an integeR?show_item.php:433whitespace instead of tab ;)show_item.php:510use TRUE as 2nd argumentshow_item.php:511use hsc()show_item.php:512use hsc()show_item.php:554use hsc()show_item.php:558use TRUE as 2nd argument -
Markus Klein commented on patch set 2 10/05/11, 14:31
I would prefer that you didn't submit this You're patch takes only [label] into account, but TCA allows many ways to specify a label: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.3.0/view/4/2/#id2517078 Use getRecordTitle -
Markus Klein commented on patch set 2 10/05/11, 14:31
You're patch takes only [label] into account, but TCA allows many ways to specify a label: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.3.0/view/4/2/#id2517078 Use t3lib_BEfunc::getRecordTitle. -
Georg Ringer commented on patch set 2 1 comment 10/05/11, 14:31
Verified; Looks good to me, but someone else must approve -
Soren Malling uploaded patch set 2 10/05/11, 14:31
-
Markus Klein commented on patch set 3 10/05/11, 14:31
Please see my response on forge. -
Markus Klein commented on patch set 3 10/05/11, 14:31
Looks good to me, but someone else must approve -
Markus Klein voted on patch set 3 V 0 10/05/11, 14:31
-
Georg Ringer commented on patch set 3 10/05/11, 14:31
Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 3 10/05/11, 14:31
(3 inline comments) Will push new version with more CGL updates and fixes for the mentioned issues.show_item.php:431CGL (variable name)show_item.php:438If the field name label is empty, why not return the original field name? CGL (indentation)show_item.php:497second parameter of getRecordTitle is the entire record, not the uid. third (optional) parameter can take care of empty titles and htmlspecialchar-ing. -
Tolleiv Nietsch commented on patch set 4 V 0 1 comment 10/05/11, 14:31
by team member; Looks good to me, approved -
Markus Klein commented on patch set 4 10/05/11, 14:31
(1 inline comment) See my comment please. -
Jigal van Hemert commented on patch set 4 10/05/11, 14:31
If the patch has enough votes, feel free to hit the submit button :-) -
Jigal van Hemert uploaded patch set 4 10/05/11, 14:31
-
Jigal van Hemert commented on patch set 4 V 0 10/05/11, 14:31
by team member; Looks good to me, approved -
Soren Malling uploaded patch set 3 10/05/11, 14:31
-
Philipp Gampe commented on patch set 3 10/05/11, 14:31
Fails Seems like something goes wrong ... have a look at the screenshots. -
Philipp Gampe commented on patch set 4 10/05/11, 14:31
Verified; Looks good to me, but someone else must approve Works for me now. -
Mr. Jenkins commented on patch set 1 10/05/11, 14:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1847/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/05/11, 14:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1849/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/05/11, 14:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1881/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/05/11, 14:31
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1988/ : SUCCESS -
Jigal van Hemert merged patch set 4 10/05/11, 14:31