Review main Merged

4971[TASK] Improve information in show_item.php

Soren Malling CR +2 V +2 Normal +84 −57 updated 06/03/13, 20:49

Commit message

Currently the "Info" popup (show_item.php) provides information with raw
data from sys_refindex. A editor will get informations such as actual
table name from the database and a uid - but no real hint to what
records it's all about.

This patch provides information about table (name shown in list module),
field name ( as shown in TCEforms) for both references tables

Screenshots in forge issue

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Jigal van Hemert +2
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Jigal van Hemert +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 23

  1. Georg Ringer commented on patch set 1 10/05/11, 14:31

    Do not submit

    show_item.php:430

    space instead of tab

    show_item.php:431

    wouldnt that be an integeR?

    show_item.php:433

    whitespace instead of tab ;)

    show_item.php:510

    use TRUE as 2nd argument

    show_item.php:511

    use hsc()

    show_item.php:512

    use hsc()

    show_item.php:554

    use hsc()

    show_item.php:558

    use TRUE as 2nd argument
  2. Markus Klein commented on patch set 2 10/05/11, 14:31

    I would prefer that you didn't submit this You're patch takes only [label] into account, but TCA allows many ways to specify a label: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.3.0/view/4/2/#id2517078 Use getRecordTitle
  3. Markus Klein commented on patch set 2 10/05/11, 14:31

    You're patch takes only [label] into account, but TCA allows many ways to specify a label: http://typo3.org/documentation/document-library/core-documentation/doc_core_api/4.3.0/view/4/2/#id2517078 Use t3lib_BEfunc::getRecordTitle.
  4. Georg Ringer commented on patch set 2 1 comment 10/05/11, 14:31

    Verified; Looks good to me, but someone else must approve
  5. Soren Malling uploaded patch set 2 10/05/11, 14:31

  6. Markus Klein commented on patch set 3 10/05/11, 14:31

    Please see my response on forge.
  7. Markus Klein commented on patch set 3 10/05/11, 14:31

    Looks good to me, but someone else must approve
  8. Markus Klein voted on patch set 3 V 0 10/05/11, 14:31

  9. Georg Ringer commented on patch set 3 10/05/11, 14:31

    Looks good to me, but someone else must approve
  10. Jigal van Hemert commented on patch set 3 10/05/11, 14:31

    (3 inline comments) Will push new version with more CGL updates and fixes for the mentioned issues.

    show_item.php:431

    CGL (variable name)

    show_item.php:438

    If the field name label is empty, why not return the original field name? CGL (indentation)

    show_item.php:497

    second parameter of getRecordTitle is the entire record, not the uid. third (optional) parameter can take care of empty titles and htmlspecialchar-ing.
  11. Tolleiv Nietsch commented on patch set 4 V 0 1 comment 10/05/11, 14:31

    by team member; Looks good to me, approved
  12. Markus Klein commented on patch set 4 10/05/11, 14:31

    (1 inline comment) See my comment please.
  13. Jigal van Hemert commented on patch set 4 10/05/11, 14:31

    If the patch has enough votes, feel free to hit the submit button :-)
  14. Jigal van Hemert uploaded patch set 4 10/05/11, 14:31

  15. Jigal van Hemert commented on patch set 4 V 0 10/05/11, 14:31

    by team member; Looks good to me, approved
  16. Soren Malling uploaded patch set 3 10/05/11, 14:31

  17. Philipp Gampe commented on patch set 3 10/05/11, 14:31

    Fails Seems like something goes wrong ... have a look at the screenshots.
  18. Philipp Gampe commented on patch set 4 10/05/11, 14:31

    Verified; Looks good to me, but someone else must approve Works for me now.
  19. Mr. Jenkins commented on patch set 1 10/05/11, 14:31

  20. Mr. Jenkins commented on patch set 2 10/05/11, 14:31

  21. Mr. Jenkins commented on patch set 3 10/05/11, 14:31

  22. Mr. Jenkins commented on patch set 4 10/05/11, 14:31

  23. Jigal van Hemert merged patch set 4 10/05/11, 14:31