Review main Merged

49711[CLEANUP] Change Enumeration::cast return doc to self

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 01/09/17, 07:28

Commit message

The Enumeration implementation has a cast() method that
does always return an instance of the enumeration
implementation itself. As the Enumeration is an abstract
type the cast() method return doc should be `self` instead
of `Enumeration`.
That does fix problems with code completion in IDEs as the
IDE does now know what exact implementation is returned.

Review

  • Code review CR +2
    • Frans Saris +2
    • Andreas Kienast +1
  • Verified V +2
    • Frans Saris +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Sascha Egerer uploaded patch set 1 09/01/16, 09:29

  2. TYPO3com voted on patch set 1 V +1 09/01/16, 09:31 Completed build in 02m 48s on Thu, 1 Sep, 11:31 AM Test Summary: 19102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2604

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 09/01/16, 09:35

  4. Frans Saris voted on patch set 1 CR +2 V +2 09/01/16, 12:22

  5. Gerrit merged patch set 1 09/01/16, 12:22

  6. Frans Saris commented on patch set 2 09/01/16, 12:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7c6491f5d6d26aecb963f62bf2bc3367ef448b22
  7. Oliver Hader commented on patch set 2 01/09/17, 07:28

    Shouldn't it be static instead of self then - with static also methods in derived classes are resolved.