Review main Merged

49715[TASK] Show hints about shortcuts and external pages in Page module

Andreas Kienast CR +2 V +2 Normal +84 −4 updated 10/06/16, 14:17

Commit message

To improve the usability, pages of the type shortcut and external link
show additional information in the page module

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Łukasz Uznański +1
    • Jörg Bösche +1
    • Michael Oehlhof +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Łukasz Uznański +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Andreas Kienast uploaded patch set 1 09/01/16, 11:22

  2. TYPO3com voted on patch set 1 V -1 09/01/16, 11:25 Completed build in 03m 00s on Thu, 1 Sep, 01:25 PM Test Summary: 19102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2624

  3. Christian Weiske commented on patch set 1 CR -1 09/01/16, 11:26

    > Uploaded patch set 1.

    locallang_layout.xlf:265

    "Page is a link to an external URL: "
  4. Georg Ringer uploaded patch set 2 09/01/16, 13:03

  5. TYPO3com voted on patch set 2 V +1 09/01/16, 13:06 Completed build in 02m 43s on Thu, 1 Sep, 03:06 PM Test Summary: 19102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2631

  6. Christian Weiske commented on patch set 2 09/01/16, 13:07

    PageLayoutController.php:564

    I'd like to be able to click on the path so that I don't have to manually search for it in the page tree.
  7. Andreas Kienast commented on patch set 2 V -1 09/01/16, 16:46

    The current solution does not work if a target page of the shortcut is not explicitly set. (like with shortcut mode "first subpage" for example).
  8. Andreas Kienast uploaded patch set 3 09/02/16, 09:44

  9. TYPO3com voted on patch set 3 V +1 09/02/16, 09:48 Completed build in 03m 22s on Fri, 2 Sep, 11:48 AM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2716

  10. Jörg Bösche voted on patch set 3 CR +1 09/03/16, 18:19

  11. Daniel Goerz uploaded patch set 4 09/07/16, 13:55

  12. Daniel Goerz voted on patch set 4 CR +1 V +1 09/07/16, 13:57

  13. Jörg Bösche voted on patch set 4 CR +1 09/07/16, 13:58

  14. TYPO3com voted on patch set 4 V +1 09/07/16, 13:58 Completed build in 03m 05s on Wed, 7 Sep, 03:58 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3012

  15. Michael Oehlhof voted on patch set 4 CR +1 V +1 09/13/16, 07:43

  16. Anja Leichsenring commented on patch set 4 CR -1 10/06/16, 11:44

    please don't merge, we use this patch on a codesprint for education.
  17. Łukasz Uznański voted on patch set 4 CR +1 V +1 10/06/16, 14:13

  18. Anja Leichsenring voted on patch set 4 CR +2 V +2 10/06/16, 14:17

  19. Gerrit merged patch set 4 10/06/16, 14:17