Review main Abandoned

49716[BUGFIX] Support mod.web_list.deniedNewTables UserTS in web > page

Christian Weiske CR 0 V 0 Easy +30 −12 updated 09/05/16, 07:30

Commit message

It is possible to disable the "create new record" button in Web > List
by setting the mod.web_list.deniedNewTables UserTSConfig setting.

Unfortunately, the tables shown in the Web > Page module always show the
"create new record" button, no respecting this setting.

This patch aligns expectations and implementation by using this setting
to hide the "create new record" button in Web > Page tables.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Christian Weiske uploaded patch set 1 09/01/16, 11:47

  2. TYPO3com voted on patch set 1 V +1 09/01/16, 11:50 Completed build in 02m 39s on Thu, 1 Sep, 01:50 PM Test Summary: 19102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2627

  3. Wouter Wolters commented on patch set 1 CR -1 09/01/16, 13:59

    Hi Christian, Thanks for your patch. A few things are not correct yet. 1. A feature can only go in master branch. No backport to 7.6. 2. A new feature needs to receive a RST file. You can create one with https://forger.typo3.org/utility/rst and place it in EXT:core/Documentation/ChangeLog/master
  4. Christian Weiske updated the commit message in patch set 2 09/02/16, 12:06

  5. TYPO3com voted on patch set 2 V +1 09/02/16, 12:10 Completed build in 03m 17s on Fri, 2 Sep, 02:10 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2730

  6. Wouter Wolters commented on patch set 2 CR -1 09/02/16, 12:17

    Should be discussed first how to deal with this setting. There are many more places in the core that should respect this setting.
  7. Georg Ringer abandoned the change 09/02/16, 13:05

    as requested by the author, this patch is abandoned as there are fare more places which needs to be touch and this should be done by adding a proper API first
  8. Christian Weiske commented on patch set 2 09/05/16, 07:30

    "requested by author" is only partially correct. I was given the impression that this patch will not be merged since it only solves a part of the problem, and this in an non-optimal way. Thus I said "then abandon it".