Review TYPO3_7-6 Merged

49717[CLEANUP] Change Enumeration::cast return doc to self

Frans Saris CR +2 V +2 Easy +1 −1 updated 09/01/16, 12:35

Commit message

The Enumeration implementation has a cast() method that
does always return an instance of the enumeration
implementation itself. As the Enumeration is an abstract
type the cast() method return doc should be `self` instead
of `Enumeration`.
That does fix problems with code completion in IDEs as the
IDE does now know what exact implementation is returned.

Review

  • Code review CR +2
    • Frans Saris +2
  • Verified V +2
    • Frans Saris +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Frans Saris commented on patch set 1 09/01/16, 12:34

    Cherry Picked from branch master.
  2. Frans Saris voted on patch set 1 CR +2 V +2 09/01/16, 12:35

  3. TYPO3com voted on patch set 1 V +1 09/01/16, 12:35 Completed build in 01m 16s on Thu, 1 Sep, 02:35 PM Test Summary: 34906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-65

  4. Gerrit merged patch set 1 09/01/16, 12:35