Review main Merged

49722[BUGFIX] Use mbstring for capitalizing a string

Georg Ringer CR +2 V +2 Easy +17 −2 updated 09/02/16, 19:21

Commit message

If mbstring is available, use mb_convert_case instead of ucwords.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Marco Huber +1
    • Philipp Gampe +1
  • Verified V +2
    • Wouter Wolters +2
    • Marco Huber +1
    • Philipp Gampe +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1822

  1. Georg Ringer uploaded patch set 1 09/01/16, 13:54

  2. Georg Ringer updated the commit message in patch set 2 09/01/16, 13:54

  3. Wouter Wolters commented on patch set 2 09/01/16, 13:56

    CharsetConverter.php:1401

    missing return?
  4. TYPO3com voted on patch set 1 V -1 09/01/16, 13:57 Completed build in 02m 49s on Thu, 1 Sep, 03:57 PM Test Summary: 2 of 19100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2639

  5. TYPO3com voted on patch set 2 V -1 09/01/16, 13:58 Completed build in 04m 20s on Thu, 1 Sep, 03:58 PM Test Summary: 2 of 19100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2640

  6. Philipp Gampe commented on patch set 2 09/01/16, 15:05

    CharsetConverter.php:1401

    just $charset

    CharsetConverter.php:1401 Reply

    Done
  7. Philipp Gampe uploaded patch set 3 09/01/16, 15:07

  8. TYPO3com voted on patch set 3 V +1 09/01/16, 15:10 Completed build in 03m 10s on Thu, 1 Sep, 05:10 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2647

  9. Philipp Gampe voted on patch set 3 CR +1 V +1 09/01/16, 15:11

  10. Wouter Wolters voted on patch set 3 CR +1 09/01/16, 16:56

  11. Andreas Kienast updated the commit message in patch set 4 09/01/16, 16:57

  12. TYPO3com voted on patch set 4 V +1 09/01/16, 17:00 Completed build in 03m 09s on Thu, 1 Sep, 07:00 PM Test Summary: 19124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2658

  13. Philipp Gampe voted on patch set 4 CR +1 V +1 09/01/16, 18:01

  14. Wouter Wolters voted on patch set 4 CR +1 09/01/16, 20:16

  15. Stefan Froemken commented on patch set 4 09/01/16, 20:57

    CharsetConverter.php:1398

    I would change them. $string first, $charset last.
  16. Wouter Wolters commented on patch set 4 09/01/16, 20:59

    CharsetConverter.php:1398 Reply

    IMO no, all other methods have this order as well and I think it would be good to have them the same.
  17. Stefan Neufeind commented on patch set 4 CR +1 09/01/16, 23:31

    too bad there is no way to also support that with iconv
  18. Georg Ringer commented on patch set 4 CR -2 09/02/16, 08:30

    for coding night
  19. Marco Huber voted on patch set 4 CR +1 V +1 09/02/16, 19:12

  20. Georg Ringer voted on patch set 4 CR 0 09/02/16, 19:12

  21. Wouter Wolters voted on patch set 4 CR +2 V +2 09/02/16, 19:21

  22. Gerrit merged patch set 4 09/02/16, 19:21