49722[BUGFIX] Use mbstring for capitalizing a string
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Marco Huber +1
- Philipp Gampe +1
-
Verified V +2
- Wouter Wolters +2
- Marco Huber +1
- Philipp Gampe +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1822
-
Georg Ringer uploaded patch set 1 09/01/16, 13:54
-
Georg Ringer updated the commit message in patch set 2 09/01/16, 13:54
-
Wouter Wolters commented on patch set 2 09/01/16, 13:56
-
TYPO3com voted on patch set 1 V -1 09/01/16, 13:57 Completed build in 02m 49s on Thu, 1 Sep, 03:57 PM Test Summary: 2 of 19100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2639
-
TYPO3com voted on patch set 2 V -1 09/01/16, 13:58 Completed build in 04m 20s on Thu, 1 Sep, 03:58 PM Test Summary: 2 of 19100 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2640
-
Philipp Gampe commented on patch set 2 09/01/16, 15:05
CharsetConverter.php:1401just $charsetCharsetConverter.php:1401ReplyDone -
Philipp Gampe uploaded patch set 3 09/01/16, 15:07
-
TYPO3com voted on patch set 3 V +1 09/01/16, 15:10 Completed build in 03m 10s on Thu, 1 Sep, 05:10 PM Test Summary: 19100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2647
-
Philipp Gampe voted on patch set 3 CR +1 V +1 09/01/16, 15:11
-
Wouter Wolters voted on patch set 3 CR +1 09/01/16, 16:56
-
Andreas Kienast updated the commit message in patch set 4 09/01/16, 16:57
-
TYPO3com voted on patch set 4 V +1 09/01/16, 17:00 Completed build in 03m 09s on Thu, 1 Sep, 07:00 PM Test Summary: 19124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2658
-
Philipp Gampe voted on patch set 4 CR +1 V +1 09/01/16, 18:01
-
Wouter Wolters voted on patch set 4 CR +1 09/01/16, 20:16
-
Stefan Froemken commented on patch set 4 09/01/16, 20:57
CharsetConverter.php:1398I would change them. $string first, $charset last. -
Wouter Wolters commented on patch set 4 09/01/16, 20:59
CharsetConverter.php:1398ReplyIMO no, all other methods have this order as well and I think it would be good to have them the same. -
Stefan Neufeind commented on patch set 4 CR +1 09/01/16, 23:31
too bad there is no way to also support that with iconv -
Georg Ringer commented on patch set 4 CR -2 09/02/16, 08:30
for coding night -
Marco Huber voted on patch set 4 CR +1 V +1 09/02/16, 19:12
-
Georg Ringer voted on patch set 4 CR 0 09/02/16, 19:12
-
Wouter Wolters voted on patch set 4 CR +2 V +2 09/02/16, 19:21
-
Gerrit merged patch set 4 09/02/16, 19:21
CharsetConverter.php:1401