Review main Merged

49735[BUGFIX] Show info about default socket

Philipp Gampe CR +2 V +2 Easy +4 −1 updated 09/02/16, 21:28

Commit message

Restore the information about using the PHP default
socket, if the value for socket is empty.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Ralf Merz +1
  • Verified V +2
    • Morton Jonuschat +2
    • Ralf Merz +1

Issues 1

Files 1

Review log 1314

  1. Philipp Gampe uploaded patch set 1 09/01/16, 20:44

  2. TYPO3com voted on patch set 1 V +1 09/01/16, 20:50 Completed build in 05m 24s on Thu, 1 Sep, 10:50 PM Test Summary: 19124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2688

  3. Morton Jonuschat commented on patch set 1 CR -1 09/02/16, 08:25

    SystemInformation.html:43

    I don't like the code duplication of the list item, the f:if can just as easily be used to just output {connection.socket} or "PHP default".
  4. Philipp Gampe commented on patch set 1 09/02/16, 08:32

    ok, guess this one qualifies for coding night
  5. Marco Huber commented on patch set 1 09/02/16, 19:25

    I will work on it, ok?
  6. Marco Huber uploaded patch set 2 09/02/16, 19:31

  7. Marco Huber uploaded patch set 3 09/02/16, 19:46

  8. Volker Kemeter voted on patch set 3 CR +1 09/02/16, 19:57

  9. Jörg Bösche voted on patch set 3 CR +1 09/02/16, 20:53

  10. Morton Jonuschat uploaded patch set 4 09/02/16, 21:05

  11. Morton Jonuschat voted on patch set 4 CR +1 V +1 09/02/16, 21:06

  12. Ralf Merz voted on patch set 4 CR +1 V +1 09/02/16, 21:24

  13. Morton Jonuschat voted on patch set 4 CR +2 V +2 09/02/16, 21:28

  14. Gerrit merged patch set 4 09/02/16, 21:28