Review main Merged

49742[TASK] Don't simulate TSFE for CropViewHelper

Benni Mack CR +2 V +2 Easy +0 −38 updated 09/02/16, 19:36

Commit message

The cObject cropping functionality was reworked quite a lot
and does not depend on TSFE anymore, so the code to simulate
TSFE object for backend requests can be removed.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Claus Due +1
    • Daniel Goerz +1
  • Verified V +2
    • Jigal van Hemert +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 09/02/16, 09:05

  2. TYPO3com voted on patch set 1 V -1 09/02/16, 09:08 Completed build in 03m 12s on Fri, 2 Sep, 11:08 AM Test Summary: 18496 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2711

  3. Wouter Wolters uploaded patch set 2 09/02/16, 13:06

  4. Claus Due voted on patch set 2 CR +1 09/02/16, 13:08

  5. TYPO3com voted on patch set 2 V +1 09/02/16, 13:10 Completed build in 03m 19s on Fri, 2 Sep, 03:10 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2735

  6. Daniel Goerz voted on patch set 2 CR +1 V +1 09/02/16, 13:49

  7. Jigal van Hemert voted on patch set 2 CR +2 V +2 09/02/16, 19:36

  8. Gerrit merged patch set 2 09/02/16, 19:36