Review main Abandoned Breaking

49746[!!!][CLEANUP] Remove unused method getRecordUidsToCopy()

Andreas Wolf CR 0 V 0 Easy +0 −27 updated 12/07/16, 11:34

Commit message

The method is declared, but not used anywhere.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1719

  1. Andreas Wolf uploaded patch set 1 09/02/16, 10:45

  2. TYPO3com voted on patch set 1 V +1 09/02/16, 10:50 Completed build in 04m 14s on Fri, 2 Sep, 12:50 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2723

  3. Daniel Maier commented on patch set 1 09/02/16, 12:31

    No Breaking-RST needed here?
  4. Wouter Wolters commented on patch set 1 CR +1 09/02/16, 12:37

    No hits on this method in TER.
  5. Daniel Maier voted on patch set 1 CR +1 09/02/16, 13:29

  6. Andreas Wolf commented on patch set 1 09/02/16, 15:11

    I’ll ask Andi Fernandez again on this one, then we can most likely remove it.
  7. Andreas Kienast voted on patch set 1 CR +1 V +1 09/02/16, 16:43

  8. Daniel Goerz voted on patch set 1 CR +1 V +1 09/02/16, 17:24

  9. Tymoteusz Motylewski commented on patch set 1 09/02/16, 22:45

    is this a correct ticket? how does it relate to this cleanup?
  10. Marc von Schalscha commented on patch set 1 CR +1 09/02/16, 22:49

    Seems ok, but as a public function it should have Breaking RST. Not every Extension is in TER.
  11. Wouter Wolters voted on patch set 1 CR 0 09/02/16, 22:54

  12. Andreas Kienast voted on patch set 1 CR 0 V 0 09/02/16, 23:07

  13. Benni Mack commented on patch set 1 CR -1 09/02/16, 23:56

    this is breaking, should only go in master and needs a simple RST: Otherwise, check if the method is used
  14. Andreas Wolf commented on patch set 1 CR -2 09/03/16, 09:37

    @Tymek: I discovered while doing this ticket that there is an unused method that was only introduced for the localization wizard. Therefore I attached the review to the same ticket; but in case we agree to have this with a full-blown breaking RST, I’ll create another ticket.
  15. Kay Strobach updated the commit message in patch set 2 09/03/16, 10:39

  16. Kay Strobach commented on patch set 2 CR -1 V -1 09/03/16, 10:42

    The Method needs to be deprecated before removing ...
  17. TYPO3com voted on patch set 2 V +1 09/03/16, 10:43 Completed build in 03m 27s on Sat, 3 Sep, 12:43 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2871

  18. Tymoteusz Motylewski commented on patch set 2 09/08/16, 19:19

    I see. As this method was not used from the start, I think we can deprecate it in v7 and remove in 8. I don't think that anybody is relaying on it since, it has no effect on how TYPO3 works.
  19. Wouter Wolters abandoned the change 12/07/16, 11:34

    Is going to be solved with https://review.typo3.org/#/c/50892/ with a deprecation instead of just removing it.