Review main Merged

49752[TASK] Use TYPO3_SSL for the URL schema enforcement test

Patrick Kollodzik CR +2 V +2 Easy +5 −3 updated 12/31/16, 14:13

Commit message

The enforement of the url_schema field should not be based
on the requested URL schema, but on the TYPO3_SSL enviroment
variable.

This will make it possible to switch the URL schema
based on enviroment variables.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Patrick Kollodzik uploaded patch set 1 09/02/16, 11:54

  2. TYPO3com voted on patch set 1 V -1 09/02/16, 11:58 Completed build in 03m 14s on Fri, 2 Sep, 01:58 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2729

  3. Patrick Kollodzik uploaded patch set 2 09/02/16, 17:45

  4. Jörg Bösche voted on patch set 2 CR +1 10/13/16, 06:19

  5. TYPO3com voted on patch set 2 V +1 10/13/16, 17:33 Completed build in 06m 29s on Thu, 13 Oct, 07:33 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3736

  6. Frank Nägler commented on patch set 2 CR -1 10/14/16, 08:46

    TypoScriptFrontendController.php:1465

    i would suggest to set a variable, instead of calling the method twice.

    TypoScriptFrontendController.php:1467

    check was == 'http' not HTTPS!
  7. Frank Nägler commented on patch set 2 10/14/16, 08:47

    imho this more a task, not a bugfix
  8. Benni Mack uploaded patch set 3 12/29/16, 08:24

  9. Benni Mack commented on patch set 3 CR +1 V +1 12/29/16, 08:25

    Hey Patrick, could you share how you change the URL schema based on environment variables?
  10. TYPO3com voted on patch set 3 V +1 12/29/16, 08:30 Completed build in 05m 03s on Thu, 29 Dec, 09:30 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6027

  11. Anja Leichsenring voted on patch set 3 CR +2 V +2 12/31/16, 14:13

  12. Gerrit merged patch set 3 12/31/16, 14:13