Review main Merged

49755[TASK] HTMLArea: Optimize path handling

Benni Mack CR +2 V +2 Normal +17 −79 updated 11/26/16, 19:55

Commit message

Use Core functionality with absolute paths
instead of own calculations.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1418

  1. Benni Mack uploaded patch set 1 09/02/16, 12:36

  2. TYPO3com voted on patch set 1 V -1 09/02/16, 12:40 Completed build in 03m 21s on Fri, 2 Sep, 02:40 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2733

  3. Benni Mack uploaded patch set 2 09/02/16, 13:53

  4. TYPO3com voted on patch set 2 V -1 09/02/16, 13:56 Completed build in 02m 56s on Fri, 2 Sep, 03:56 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2740

  5. Benni Mack uploaded patch set 3 09/02/16, 13:58

  6. TYPO3com voted on patch set 3 V +1 09/02/16, 14:02 Completed build in 03m 44s on Fri, 2 Sep, 04:02 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2741

  7. Tymoteusz Motylewski commented on patch set 3 09/02/16, 17:13

    how it can be tested? Do we need a breaking rst here?
  8. Benni Mack commented on patch set 3 09/02/16, 22:44

    easy - if the RTE still works, it's fine. it's actually non-breaking as it only replaces paths with absolute paths and all plugins of RTEhtmlarea still work as is.
  9. Wouter Wolters voted on patch set 3 CR +1 V +1 09/03/16, 08:38

  10. Andreas Kienast commented on patch set 3 V -1 09/03/16, 08:40

    Loading CSS may fail: Resource interpreted as Stylesheet but transferred with MIME type text/html: "http://dev-master.local.typo3.org/typo3/typo3conf/ext/bootstrap_package/Resources/Public/Css/RTE/rte.css";. Note typo3/typo3conf
  11. Andreas Kienast uploaded patch set 4 09/03/16, 08:49

  12. Andreas Kienast commented on patch set 4 V +1 09/03/16, 08:51

    Waiting for CR+1 until Benni verified the one-line change.
  13. Benni Mack voted on patch set 4 CR +1 09/03/16, 08:52

  14. TYPO3com voted on patch set 4 V +1 09/03/16, 08:54 Completed build in 04m 12s on Sat, 3 Sep, 10:54 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2845

  15. Andreas Kienast voted on patch set 4 CR +1 09/03/16, 08:54

  16. Wouter Wolters voted on patch set 4 CR +2 V +2 09/03/16, 09:00

  17. Gerrit merged patch set 4 09/03/16, 09:00

  18. Markus Klein commented on patch set 5 11/26/16, 19:55

    RichTextElement.php:241