Review main Abandoned

49763[TASK] Allow "entryPointLevel" as parameter in Application constructor

Markus Hölzle CR 0 V 0 Easy +5 −1 updated 10/25/17, 05:56

Commit message

Allow "entryPointLevel" as parameter in "Application" constructor
to support simple calls in "subdirectory-hosted" projects.
This is required for installations with a "secure frontend".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1518

  1. Markus Hölzle uploaded patch set 1 09/02/16, 14:15

  2. TYPO3com voted on patch set 1 V +1 09/02/16, 14:18 Completed build in 03m 02s on Fri, 2 Sep, 04:18 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2743

  3. Markus Hölzle uploaded patch set 2 02/23/17, 08:48

  4. TYPO3com voted on patch set 2 V +1 02/23/17, 08:55 Completed build in 06m 30s on Thu, 23 Feb, 09:55 AM Test Summary: 56411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8387

  5. Timo Hund voted on patch set 2 CR +1 02/23/17, 13:01

  6. Benni Mack commented on patch set 2 CR -1 03/28/17, 20:01

    Hey Markus, you#re aware that this is heavily breaking as the application does not follow the interface anymore?
  7. Benni Mack commented on patch set 2 CR 0 07/31/17, 05:13

    I was wrong, the constructor is not part of the interface. So, I removed my -1.
  8. Benni Mack commented on patch set 2 07/31/17, 05:13

    FYI: When in composer mode, the entryPointLevel is not evaluated at all, question is if we still need this option then...
  9. Markus Hölzle commented on patch set 2 07/31/17, 09:54

    I think it is still needed if you want a really secured TYPO3 installation. With the composer option "web-dir" the vendor folder is not reachable from the web. But if you want nothing, except the index.php file (and of course some other symlinks for "typo3temp" or "fileadmmin") is reachable from the public web, then you have to set this option.
  10. Markus Hölzle commented on patch set 2 07/31/17, 09:58

    The perfect solution would be if you can configure this via composer.json settings of course ;-)
  11. Sonja Großewinkelmann commented on patch set 2 09/25/17, 08:48

    Application.php

    I wonder if the if condition is really needed here. Why not just setting the entryPointLevel?
  12. Andreas Kienast commented on patch set 2 09/25/17, 08:50

    Application.php:54

    I'd change this to >= 0
  13. Jörg Bösche uploaded patch set 3 10/23/17, 09:15

  14. TYPO3com voted on patch set 3 V +1 10/23/17, 09:23 Completed build in 08m 08s on Mon, 23 Oct, 11:23 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15851

  15. Helmut Hummel commented on patch set 3 CR -1 10/23/17, 12:31

    @Markus: Do you need this for composer based projects or non composer based projects?
  16. Markus Hölzle commented on patch set 3 10/24/17, 17:08

    @Helmut: Yes, for composer based projects
  17. Helmut Hummel commented on patch set 3 CR -2 10/24/17, 17:26

    Then just require https://packagist.org/packages/helhum/typo3-secure-web works well with TYPO3 8.7 already and does not require a single change in the core Configuration is pretty simple: https://github.com/helhum/TYPO3-Distribution/blob/4b08257661daaadb5c7a6e48e857aea332d0e735/composer.json#L55-L56 We still need to figure out how to make this more convenient for non composer based projects, but this change here does not help in that regard either.
  18. Benni Mack abandoned the change 10/25/17, 05:56

    yes. entryPointLevel is actually a nasty workaround for the current non-composer modes, I will abandon this patch (and the approach) for now.