49764[TASK] Remove unused local variables
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jan Helke +1
- Łukasz Uznański +1
-
Verified V +2
- Christian Kuhn +2
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 53
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php+0 −1
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php+0 −1
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+0 −5
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+0 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+0 −1
- typo3/sysext/backend/Classes/Tree/View/FolderTreeView.php+0 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php1+0 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+0 −1
- typo3/sysext/compatibility7/Classes/Controller/SearchFormController.php+0 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+1 −1
- typo3/sysext/core/Classes/Database/RelationHandler.php+0 −1
- typo3/sysext/core/Classes/Database/SoftReferenceIndex.php+1 −4
- typo3/sysext/core/Tests/Unit/Cache/Frontend/AbstractFrontendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/RequestTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/ResponseTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Http/UriTest.php+7 −7
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+1 −1
Show 33 more files
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+0 −1
- typo3/sysext/core/Tests/Unit/FileStreamWrapperTest.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Security/Cryptography/HashServiceTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractCompositeValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/EscapeChildrenRenderingTest.php+0 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Format/DateViewHelperTest.php+0 −3
- typo3/sysext/form/Classes/PostProcess/MailPostProcessor.php+0 −4
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+0 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −1
- typo3/sysext/indexed_search/Classes/Indexer.php1+0 −5
- typo3/sysext/install/Classes/Controller/Action/Tool/CleanUp.php+1 −1
- typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php+1 −1
- typo3/sysext/install/Classes/Updates/ExtensionManagerTables.php1+1 −2
- typo3/sysext/lowlevel/Classes/MissingFilesCommand.php+0 −1
- typo3/sysext/lowlevel/Classes/OrphanRecordsCommand.php+0 −1
- typo3/sysext/rsaauth/Tests/Functional/Storage/SplitStorageTest.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/ParseHtmlController.php+0 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/SpellCheckingController.php+0 −2
- typo3/sysext/rtehtmlarea/Classes/Extension/Language.php1+0 −1
- typo3/sysext/saltedpasswords/Classes/Salt/BlowfishSalt.php+0 −1
- typo3/sysext/saltedpasswords/Classes/Salt/Md5Salt.php+0 −1
- typo3/sysext/saltedpasswords/Classes/Salt/PhpassSalt.php+0 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/BlowfishSaltTest.php+0 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerCliController.php+1 −1
- typo3/sysext/scheduler/Classes/CronCommand/CronCommand.php+0 −1
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+0 −3
- typo3/sysext/version/Classes/Hook/DataHandlerHook.php+1 −3
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+0 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php1+0 −1
Review log 1520
-
Wouter Wolters uploaded patch set 1 09/02/16, 14:47
-
TYPO3com voted on patch set 1 V -1 09/02/16, 14:50 Completed build in 03m 07s on Fri, 2 Sep, 04:50 PM Test Summary: 18501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2748
-
Wouter Wolters uploaded patch set 2 09/02/16, 15:02
-
TYPO3com voted on patch set 2 V -1 09/02/16, 15:05 Completed build in 02m 57s on Fri, 2 Sep, 05:05 PM Test Summary: 18501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2749
-
Wouter Wolters uploaded patch set 3 09/02/16, 15:41
-
Wouter Wolters updated the commit message in patch set 4 09/02/16, 22:39
-
TYPO3com voted on patch set 4 V -1 09/02/16, 22:42 Completed build in 03m 31s on Sat, 3 Sep, 12:42 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2790
-
Wouter Wolters uploaded patch set 5 09/03/16, 08:32
-
TYPO3com voted on patch set 5 V +1 09/03/16, 08:35 Completed build in 03m 01s on Sat, 3 Sep, 10:35 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2841
-
Benni Mack commented on patch set 5 09/03/16, 08:45
-
Wouter Wolters commented on patch set 5 09/28/16, 08:42
BackendUserAuthentication.php:511Replylooks like you are right here. but that belongs to another tciket than. -
Michael Oehlhof commented on patch set 5 CR -1 09/30/16, 20:34
BackendUtility.php:24This line is already removed in current master.ExtensionManagerTables.php:135This variable is used in line 147Language.php:119This is already removed in current masterStagesService.php:262Why do you move the param to the top of the comment? -
Benni Mack commented on patch set 5 10/04/16, 04:49
Indexer.php:908the two lines above can be removed then as well (by reading) -
Benni Mack uploaded patch set 6 10/08/16, 19:23
-
TYPO3com voted on patch set 6 V +1 10/08/16, 19:28 Completed build in 04m 57s on Sat, 8 Oct, 09:28 PM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3495
-
Jan Helke voted on patch set 6 CR +1 V +1 10/09/16, 11:04
-
Łukasz Uznański voted on patch set 6 CR +1 10/09/16, 11:09
-
Christian Kuhn commented on patch set 6 CR -1 10/09/16, 11:11
on it. -
Christian Kuhn voted on patch set 6 CR +2 V +2 10/09/16, 11:27
-
Gerrit merged patch set 6 10/09/16, 11:27
BackendUserAuthentication.php:511