Review main Merged

49764[TASK] Remove unused local variables

Wouter Wolters CR +2 V +2 Normal +34 −93 updated 10/09/16, 11:27

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
    • Łukasz Uznański +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 53

Show 33 more files

Review log 1520

  1. Wouter Wolters uploaded patch set 1 09/02/16, 14:47

  2. TYPO3com voted on patch set 1 V -1 09/02/16, 14:50 Completed build in 03m 07s on Fri, 2 Sep, 04:50 PM Test Summary: 18501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2748

  3. Wouter Wolters uploaded patch set 2 09/02/16, 15:02

  4. TYPO3com voted on patch set 2 V -1 09/02/16, 15:05 Completed build in 02m 57s on Fri, 2 Sep, 05:05 PM Test Summary: 18501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2749

  5. Wouter Wolters uploaded patch set 3 09/02/16, 15:41

  6. Wouter Wolters updated the commit message in patch set 4 09/02/16, 22:39

  7. TYPO3com voted on patch set 4 V -1 09/02/16, 22:42 Completed build in 03m 31s on Sat, 3 Sep, 12:42 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2790

  8. Wouter Wolters uploaded patch set 5 09/03/16, 08:32

  9. TYPO3com voted on patch set 5 V +1 09/03/16, 08:35 Completed build in 03m 01s on Sat, 3 Sep, 10:35 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2841

  10. Benni Mack commented on patch set 5 09/03/16, 08:45

    BackendUserAuthentication.php:511

    I wonder if this code even works right now because we should do &$constraint, right?
  11. Wouter Wolters commented on patch set 5 09/28/16, 08:42

    BackendUserAuthentication.php:511 Reply

    looks like you are right here. but that belongs to another tciket than.
  12. Michael Oehlhof commented on patch set 5 CR -1 09/30/16, 20:34

    BackendUtility.php:24

    This line is already removed in current master.

    ExtensionManagerTables.php:135

    This variable is used in line 147

    Language.php:119

    This is already removed in current master

    StagesService.php:262

    Why do you move the param to the top of the comment?
  13. Benni Mack commented on patch set 5 10/04/16, 04:49

    Indexer.php:908

    the two lines above can be removed then as well (by reading)
  14. Benni Mack uploaded patch set 6 10/08/16, 19:23

  15. TYPO3com voted on patch set 6 V +1 10/08/16, 19:28 Completed build in 04m 57s on Sat, 8 Oct, 09:28 PM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3495

  16. Jan Helke voted on patch set 6 CR +1 V +1 10/09/16, 11:04

  17. Łukasz Uznański voted on patch set 6 CR +1 10/09/16, 11:09

  18. Christian Kuhn commented on patch set 6 CR -1 10/09/16, 11:11

    on it.
  19. Christian Kuhn voted on patch set 6 CR +2 V +2 10/09/16, 11:27

  20. Gerrit merged patch set 6 10/09/16, 11:27