Review main Merged

49771[BUGFIX] FormViewHelper can handle empty string as pageUid

Frans Saris CR +2 V +2 Easy +2 −1 updated 10/21/16, 08:35

Commit message

The FormViewHelper now can handle a empty string value passed through
the pageUid attribute and handles is as value not set so current pageUid
is used.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Gohlke +1
    • Tymoteusz Motylewski +1
    • Markus Gehrig +1
  • Verified V +2
    • Wouter Wolters +2
    • Tymoteusz Motylewski +1

Issues 1

Files 1

Review log 8

  1. Frans Saris uploaded patch set 1 09/02/16, 16:18

  2. Wouter Wolters voted on patch set 1 CR +1 09/02/16, 19:04

  3. Daniel Gohlke voted on patch set 1 CR +1 09/02/16, 19:06

  4. Markus Gehrig voted on patch set 1 CR +1 09/02/16, 20:16

  5. Tymoteusz Motylewski voted on patch set 1 CR +1 V +1 09/03/16, 10:06

  6. Wouter Wolters voted on patch set 1 CR +2 V +2 09/03/16, 10:13

  7. Gerrit merged patch set 1 09/03/16, 10:13

  8. Helmut Hummel commented on patch set 2 10/21/16, 08:35

    Besides the regression introduced by this (see https://github.com/TYPO3/TYPO3.CMS/commit/50bc19b5fbd43493277576daef51e7a33bf168b0#commitcomment-19482939), why is this fixed in the view helper and not the uri builder? how do all other uri view helpers behave on empty string for pageUid? I think they should behave the same.