Review main Merged Breaking

49776[!!!][BUGFIX] Fix behaviour of RecordCollectionRepository in FE mode

Felix Rauch CR +2 V +2 Normal +219 −3 updated 09/02/16, 21:35

Commit message

RecordCollectionRepository::findByUid does not respect the enable
columns configured in TCA when TYPO3 is in FE mode. This commit fixes
that behaviour by introducing a check for the TYPO3 environment mode,
and acting accordingly.

This change is potentially breaking, as any consumer of the
RecordCollectionRepository API who expects the faulty behaviour will
have to override the used table's TCA to return to the previous
behaviour.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Morton Jonuschat +1
  • Verified V +2
    • Wouter Wolters +2
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 11

  1. Felix Rauch uploaded patch set 1 09/02/16, 17:53

  2. Morton Jonuschat uploaded patch set 2 09/02/16, 18:06

  3. Morton Jonuschat uploaded patch set 3 09/02/16, 18:07

  4. Morton Jonuschat voted on patch set 3 CR +1 V +1 09/02/16, 18:08

  5. Wouter Wolters commented on patch set 4 09/02/16, 19:01

    Published edit on patch set 3.
  6. Morton Jonuschat voted on patch set 4 CR +1 V +1 09/02/16, 21:29

  7. Wouter Wolters voted on patch set 4 CR +2 V +2 09/02/16, 21:29

  8. Wouter Wolters uploaded patch set 5 09/02/16, 21:30

  9. Morton Jonuschat voted on patch set 5 CR +1 V +1 09/02/16, 21:31

  10. Wouter Wolters voted on patch set 5 CR +2 V +2 09/02/16, 21:35

  11. Gerrit merged patch set 5 09/02/16, 21:35