Review main Merged

49787[BUGFIX] Doctrine: Fix SchemaMigrator renaming columns instead of adding

Morton Jonuschat CR +2 V +2 Easy +14 −1 updated 09/02/16, 20:29

Commit message

When a partial SQL file doesn't include an existing column that is exactly
the same configuration as a new column the Doctrine SchemaManager falsely
detects a column rename. Convert these renamed columns to newly added columns.

Review

  • Code review CR +2
    • Jan Helke +2
    • Marco Bresch +1
  • Verified V +2
    • Jan Helke +2
    • Marco Bresch +1

Issues 1

Files 2

Review log 7

  1. Morton Jonuschat uploaded patch set 1 09/02/16, 19:59

  2. Marco Bresch commented on patch set 1 V +1 09/02/16, 20:15

    The Introduction- and Bootstrap-Package works fine again. :-)
  3. Marco Bresch commented on patch set 2 09/02/16, 20:21

    Published edit on patch set 1.
  4. Marco Bresch commented on patch set 2 V +1 09/02/16, 20:22

    Just fixed a typo in a comment in patch set 2
  5. Marco Bresch voted on patch set 2 CR +1 09/02/16, 20:28

  6. Jan Helke voted on patch set 2 CR +2 V +2 09/02/16, 20:29

  7. Gerrit merged patch set 2 09/02/16, 20:29