49806[FEATURE] Display TCA migration messages in Install Tool
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Andreas Kienast +1
-
Verified V +2
- Morton Jonuschat +2
- Andreas Kienast +1
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-77799-DisplayTCAMigrationMessagesInInstallTool.rstnew+14 −0
- typo3/sysext/install/Classes/Controller/Action/Tool/ImportantActions.php+34 −0
- typo3/sysext/install/Classes/Service/LoadTcaService.phpnew+91 −0
- typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/TcaMigrations.htmlnew+8 −0
- typo3/sysext/install/Resources/Private/Templates/Action/Tool/ImportantActions.html+3 −0
Review log 1419
-
Philipp Gampe uploaded patch set 1 09/02/16, 21:56
-
Philipp Gampe uploaded patch set 2 09/02/16, 21:59
-
TYPO3com voted on patch set 1 V -1 09/02/16, 21:59 Completed build in 03m 07s on Fri, 2 Sep, 11:59 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2775
-
TYPO3com voted on patch set 2 V +1 09/02/16, 22:03 Completed build in 03m 37s on Sat, 3 Sep, 12:03 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2777
-
Andreas Kienast voted on patch set 2 CR +1 V +1 09/02/16, 22:09
-
Daniel Goerz commented on patch set 2 09/02/16, 22:20
I like it! Do we need a rst for this? -
Morton Jonuschat commented on patch set 2 09/02/16, 23:04
I think the message are very "loud". Maybe we should use the smaller font size and also show the current and migrated states on separate lines below the headline, possibly even in a fixed width font? -
Philipp Gampe commented on patch set 2 09/02/16, 23:11
@Morton those messages come directly from the migration service. If we want to improve this, we have to change the migrations service first to return an array (or even objects). On top of this, we cannot change the install tool UI at this point easily without making the UX very bad. -
Philipp Gampe uploaded patch set 3 09/02/16, 23:42
-
TYPO3com voted on patch set 3 V -1 09/02/16, 23:45 Completed build in 03m 25s on Sat, 3 Sep, 01:45 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2814
-
Andreas Wolf uploaded patch set 4 09/03/16, 00:26
-
Andreas Wolf voted on patch set 4 V +1 09/03/16, 00:27
-
TYPO3com voted on patch set 4 V +1 09/03/16, 00:29 Completed build in 03m 29s on Sat, 3 Sep, 02:29 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2822
-
Andreas Kienast commented on patch set 4 09/03/16, 07:46
@Daniel: Yes, we need a ReST for this, as it's a feature. I totally overlooked that yesterday evening. -
Wouter Wolters uploaded patch set 5 09/03/16, 09:07
-
Andreas Kienast voted on patch set 5 CR +1 V +1 09/03/16, 09:09
-
Morton Jonuschat voted on patch set 5 CR +2 V +2 09/03/16, 09:09
-
Gerrit merged patch set 5 09/03/16, 09:09
-
TYPO3com commented on patch set 5 09/03/16, 09:12 Completed build in 04m 12s on Sat, 3 Sep, 11:12 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2849