49808[TASK] Fluidification of NewContentElementController
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Daniel Goerz +1
- Markus Sommer +1
- Alexander Stehlik +1
- Jörg Bösche +1
- Michael Oehlhof +1
- Philipp Gampe +1
-
Verified V +2
- Jan Helke +2
- Daniel Goerz +1
- Markus Sommer +1
- Michael Oehlhof +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 3137
Show 1012 earlier messages
-
Marc Willmann uploaded patch set 1 09/02/16, 22:24
-
TYPO3com voted on patch set 1 V -1 09/02/16, 22:27 Completed build in 03m 09s on Sat, 3 Sep, 12:27 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2785
-
Marc Willmann uploaded patch set 2 09/02/16, 22:47
-
TYPO3com voted on patch set 2 V +1 09/02/16, 22:53 Completed build in 06m 00s on Sat, 3 Sep, 12:53 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2798
-
Patrick Kollodzik voted on patch set 2 V -1 09/02/16, 23:06
-
Patrick Kollodzik voted on patch set 2 V +1 09/02/16, 23:06
-
Marco Bresch commented on patch set 2 V +1 09/02/16, 23:20
Tested successfull -
Alexander Stehlik voted on patch set 2 CR +1 V +1 09/03/16, 00:07
-
Philipp Gampe commented on patch set 2 CR -1 09/03/16, 00:12
NewContentElementController.php:279please use speaking variable names for the Fluid template -
Marco Bresch commented on patch set 2 09/03/16, 07:22
NewContentElementController.php:194Unused variable $lang -
Marc Willmann uploaded patch set 3 09/03/16, 12:35
-
Marc Willmann commented on patch set 3 09/03/16, 12:39
@Philipp Game: I basically agree, but the (given) code is kind of messy. So do you have good suggestions for good speaking names for those variables? @Marco Brasch: thanks for this hint - I've corrected this.
-
TYPO3com voted on patch set 3 V +1 09/03/16, 12:39 Completed build in 03m 15s on Sat, 3 Sep, 02:39 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2884
-
Philipp Gampe commented on patch set 3 09/03/16, 15:12
NewContentElementController.php:194please invert -> $hasAccess = trueNewContentElementController.php:273same as above? -> Drop the line above.NewContentElementController.php:274not sure here, kind of OKNewContentElementController.php:275wizardInformationNewContentElementController.php:277wizardOnClickNewContentElementController.php:278wizardKeyNewContentElementController.php:308$hasAccess = falseMain.html:1please invert for better readability -
Philipp Gampe voted on patch set 3 CR -1 09/03/16, 15:12
-
Marc Willmann uploaded patch set 4 09/03/16, 16:11
-
Marc Willmann commented on patch set 4 09/03/16, 16:15
Thanks Philipp to make this more clear. I've updated the code to make the variable more readable.NewContentElementController.php:251this goes to another view; so this line is not a duplicate. -
TYPO3com voted on patch set 4 V +1 09/03/16, 16:15 Completed build in 03m 33s on Sat, 3 Sep, 06:15 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2940
-
Marco Bresch commented on patch set 4 V +1 09/04/16, 07:37
Works fine -
Alexander Stehlik commented on patch set 4 CR -1 09/04/16, 10:29
NewContentElementController.php:131Property declaration is missing.NewContentElementController.php:572Please add type hints for $filename and the return value. -
Alexander Stehlik uploaded patch set 5 09/04/16, 12:36
-
Alexander Stehlik commented on patch set 5 CR +1 V +1 09/04/16, 12:37
Fixed some code style issues, should be fine now :) -
TYPO3com voted on patch set 5 V +1 09/04/16, 12:40 Completed build in 03m 14s on Sun, 4 Sep, 02:40 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2975
-
Marco Bresch voted on patch set 5 CR +1 V +1 09/09/16, 08:49
-
Michael Oehlhof voted on patch set 5 CR +1 V +1 09/09/16, 14:19
-
Daniel Goerz commented on patch set 5 CR -1 09/09/16, 15:11
on it -
Daniel Goerz uploaded patch set 6 09/09/16, 15:18
-
Daniel Goerz commented on patch set 6 CR +1 V +1 09/09/16, 15:20
Fixed indention, wraped templates in html tag, reduced code in getFluidTemplateObject(), rephrased commit message. -
TYPO3com voted on patch set 6 V +1 09/09/16, 15:21 Completed build in 02m 55s on Fri, 9 Sep, 05:21 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3039
-
Alexander Stehlik voted on patch set 6 CR +1 09/09/16, 16:09
-
Philipp Gampe voted on patch set 6 CR +1 09/14/16, 15:00
-
Jörg Bösche voted on patch set 6 CR +1 09/26/16, 19:16
-
Markus Sommer voted on patch set 6 CR +1 09/30/16, 08:50
-
Markus Sommer voted on patch set 6 V +1 09/30/16, 10:00
-
Michael Oehlhof voted on patch set 6 CR +1 V +1 09/30/16, 19:29
-
Jan Helke voted on patch set 6 CR +2 V +2 10/07/16, 08:10
-
Gerrit merged patch set 6 10/07/16, 08:10