49810[TASK] Fluidification of ShortcutToolbarItem
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Alexander Stehlik +1
- Jörg Bösche +1
-
Verified V +2
- Susi Moog +2
- Alexander Stehlik +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php1+62 −97
- typo3/sysext/backend/Resources/Private/Partials/ShortcutToolbarItem/Shortcut.htmlnew+31 −0
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/DropDown.htmlnew+33 −0
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/EditForm.htmlnew+19 −0
- typo3/sysext/backend/Resources/Private/Templates/ShortcutToolbarItem/Item.html2new+7 −0
- typo3/sysext/lang/Resources/Private/Language/locallang_misc.xlf1+1 −1
Review log 2026
Show 1 earlier messages
-
Patrick Kollodzik uploaded patch set 1 09/02/16, 22:30
-
TYPO3com voted on patch set 1 V -1 09/02/16, 22:36 Completed build in 05m 21s on Sat, 3 Sep, 12:36 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2788
-
Patrick Kollodzik uploaded patch set 2 09/02/16, 22:46
-
TYPO3com voted on patch set 2 V +1 09/02/16, 22:52 Completed build in 05m 20s on Sat, 3 Sep, 12:52 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2797
-
Marc Willmann voted on patch set 2 CR +1 V +1 09/02/16, 23:08
-
Daniel Goerz commented on patch set 2 09/03/16, 10:20
Item.html:1I would wrapp new templates in <html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true"> ... </html> -
Patrick Kollodzik commented on patch set 2 09/03/16, 13:38
I didn't know about the icon ViewHelper and will adjust the code. -
Patrick Kollodzik uploaded patch set 3 09/03/16, 14:04
-
TYPO3com voted on patch set 3 V +1 09/03/16, 14:08 Completed build in 03m 07s on Sat, 3 Sep, 04:08 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2903
-
Daniel Goerz commented on patch set 3 CR -1 09/03/16, 15:20
Item.html:1Please use the xmlns for the core namespace as well and remove this line. xmlns:core="http://typo3.org/ns/TYPO3/CMS/Core/ViewHelpers" Just add this to the html tag, it should import the namespace. -
Patrick Kollodzik uploaded patch set 4 09/03/16, 15:40
-
TYPO3com voted on patch set 4 V +1 09/03/16, 15:43 Completed build in 02m 56s on Sat, 3 Sep, 05:43 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2937
-
Jan Helke commented on patch set 4 CR -1 12/04/16, 11:10
Will rebase -
Jan Helke uploaded patch set 5 12/04/16, 18:52
-
TYPO3com voted on patch set 5 V +1 12/04/16, 18:58 Completed build in 05m 34s on Sun, 4 Dec, 07:58 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5518
-
Alexander Stehlik commented on patch set 5 12/04/16, 19:04
Any reason why xmlns is defined only in EditForm.html? Are there any guidelines for the core when it should be used? -
Alexander Stehlik commented on patch set 5 V +1 12/04/16, 19:15
Works as before, will Code-Review +1 as soon as I got feedback about the xmlns question ;) -
Alexander Stehlik commented on patch set 5 12/04/16, 19:23
Found some usability issues while testing, created https://forge.typo3.org/issues/78881 -
Jan Helke uploaded patch set 6 12/04/16, 20:39
-
Jan Helke commented on patch set 6 12/04/16, 20:41
The xmlns was a leftover from the former version of this patch. I removed it now, because I see no reason to have those definitions in the core. -
TYPO3com voted on patch set 6 V +1 12/04/16, 20:43 Completed build in 03m 44s on Sun, 4 Dec, 09:43 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5520
-
Alexander Stehlik voted on patch set 6 CR +1 V +1 12/04/16, 20:55
-
Jörg Bösche voted on patch set 6 CR +1 12/06/16, 07:33
-
Susi Moog voted on patch set 6 CR +2 V +2 12/07/16, 11:30
-
Gerrit merged patch set 6 12/07/16, 11:30
-
Alexander Opitz commented on patch set 7 12/12/16, 16:44
Post -1locallang_misc.xlf:94This change isn't in translations, so the Backend fails with: #1476107295: PHP Warning: vsprintf(): Too few arguments in /home/opitz/projects/typo3-master/typo3_src-git/typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php line 117
ShortcutToolbarItem.php:149