Review main Merged

49848[BUGFIX] Scheduler: fix and add missing CSH labels

Josef Glatz CR +2 V +2 Easy +22 −10 updated 09/12/16, 14:52

Commit message

Activate CSH labels while creating a new scheduler task.
Also add missing localization strings for common description
field.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Josef Glatz uploaded patch set 1 09/03/16, 16:21

  2. TYPO3com voted on patch set 1 V +1 09/03/16, 16:25 Completed build in 03m 05s on Sat, 3 Sep, 06:25 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2942

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/03/16, 18:35

  4. Tymoteusz Motylewski commented on patch set 1 09/03/16, 22:40

    SchedulerModuleController.php:724

    why the "for" attribute was removed?
  5. Georg Ringer commented on patch set 1 09/04/16, 07:07

    SchedulerModuleController.php:724 Reply

    check out formengine which doesn't have that as well. clicking the labels doesn't trigger the csh to come up
  6. Daniel Goerz commented on patch set 2 09/04/16, 08:47

    Published edit on patch set 1.
  7. Daniel Goerz voted on patch set 2 CR +1 V +1 09/04/16, 08:48

  8. TYPO3com voted on patch set 2 V +1 09/04/16, 08:50 Completed build in 02m 52s on Sun, 4 Sep, 10:50 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2954

  9. Josef Glatz voted on patch set 2 CR +1 V +1 09/04/16, 11:24

  10. Riccardo De Contardi commented on patch set 2 V +1 09/06/16, 19:59

    All labels seem to work now
  11. Josef Glatz rebased onto patch set 3 09/08/16, 05:08

  12. TYPO3com voted on patch set 3 V +1 09/08/16, 05:12 Completed build in 03m 22s on Thu, 8 Sep, 07:12 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3016

  13. Michael Oehlhof voted on patch set 3 CR +1 V +1 09/09/16, 14:32

  14. Daniel Goerz voted on patch set 3 CR +1 V +1 09/09/16, 15:01

  15. Georg Ringer voted on patch set 3 CR +2 V +2 09/12/16, 14:52

  16. Gerrit merged patch set 3 09/12/16, 14:52