Review main Merged

49852[BUGFIX] Do not throw exception for inaccessible folders

Sascha Egerer CR +2 V +2 Easy +4 −2 updated 10/08/16, 14:59

Commit message

In the LocalDriver the PHP RecursiveIteratorIterator implementation is
used to recursively iterate over a directory.
If there is a resource child with limited access an exception is thrown
during the initialization of the iterator.
That means you are even not able to iterate over the other folders.

This patch adds a flag that prevents the iterator to throw the exception.

Review

  • Code review CR +2
    • Jan Helke +2
    • Karol Lamparski +1
    • Anja Leichsenring +1
    • Zbigniew Jacko +1
  • Verified V +2
    • Jan Helke +2
    • Karol Lamparski +1
    • Anja Leichsenring +1
    • Zbigniew Jacko +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1518

  1. Sascha Egerer uploaded patch set 1 09/04/16, 08:53

  2. TYPO3com voted on patch set 1 V +1 09/04/16, 08:56 Completed build in 03m 12s on Sun, 4 Sep, 10:56 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2958

  3. Frans Saris voted on patch set 1 CR +1 09/06/16, 06:49

  4. Nicole Hummel updated the commit message in patch set 2 09/08/16, 22:12

  5. Nicole Hummel voted on patch set 2 CR +1 09/08/16, 22:12

  6. TYPO3com voted on patch set 2 V +1 09/08/16, 22:15 Completed build in 03m 49s on Fri, 9 Sep, 12:15 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3022

  7. Daniel Goerz voted on patch set 2 CR +1 09/09/16, 15:57

  8. Stefan Neufeind voted on patch set 2 CR +1 09/19/16, 08:42

  9. Stefan Neufeind commented on patch set 2 CR 0 09/22/16, 22:09

    During trying to test this I stumbled across another corner-case. I'm not sure it's directly related to this patch. Until clarified with Sascha directly I'm therefor removing my vote here.
  10. Frank Nägler voted on patch set 2 CR +1 V +1 10/07/16, 08:19

  11. Anja Leichsenring updated the commit message in patch set 3 10/08/16, 08:52

  12. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/08/16, 08:52

  13. TYPO3com voted on patch set 3 V +1 10/08/16, 08:56 Completed build in 03m 40s on Sat, 8 Oct, 10:56 AM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3435

  14. Zbigniew Jacko voted on patch set 3 CR +1 V +1 10/08/16, 08:58

  15. Karol Lamparski commented on patch set 3 CR +1 V +1 10/08/16, 09:03

    > Patch Set 3: Commit message was updated.
  16. Jan Helke voted on patch set 3 CR +2 V +2 10/08/16, 14:59

  17. Gerrit merged patch set 3 10/08/16, 14:59

  18. Jan Helke commented on patch set 4 10/08/16, 14:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 7bbc54eb6ea75d0daa40f4dd9c929bbfe4cf2d70