Review main Merged

49853[TASK] Scheduler: Move server time info to a partial

Daniel Goerz CR +2 V +2 Easy +23 −14 updated 09/28/16, 07:34

Commit message

Additionally the appearance is improved by using an infobox
and the infobox is added to the check view as well.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Ralf Merz +1
    • Robert van Kammen +1
    • Jörg Bösche +1
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Robert van Kammen +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2327

Show 12 earlier messages
  1. Daniel Goerz uploaded patch set 1 09/04/16, 09:19

  2. TYPO3com voted on patch set 1 V +1 09/04/16, 09:22 Completed build in 03m 11s on Sun, 4 Sep, 11:22 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2961

  1. Daniel Maier voted on patch set 1 CR +1 09/04/16, 09:36

  2. Daniel Goerz commented on patch set 1 CR -1 09/04/16, 09:37

    still on it
  3. Daniel Goerz uploaded patch set 2 09/04/16, 09:46

  4. Daniel Goerz uploaded patch set 3 09/04/16, 09:47

  5. Daniel Goerz commented on patch set 3 09/04/16, 09:49

    I added the info to the check view because it makes total sense to not exclude one important information about the setup (server time) there.
  6. TYPO3com voted on patch set 2 V +1 09/04/16, 09:52 Completed build in 06m 17s on Sun, 4 Sep, 11:52 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2967

  7. TYPO3com voted on patch set 3 V +1 09/04/16, 09:55 Completed build in 07m 54s on Sun, 4 Sep, 11:55 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2970

  8. Ralf Merz voted on patch set 3 CR +1 V +1 09/07/16, 07:47

  9. Michael Oehlhof voted on patch set 3 CR +1 V +1 09/13/16, 07:50

  10. Stefan Neufeind commented on patch set 3 CR +1 V +1 09/19/16, 08:14

    imho not for 7.6 as it isn't important
  11. Daniel Goerz commented on patch set 3 09/19/16, 08:30

    > (1 comment) Sure. Not mandatory. But an UI and usability improvement that should be a straight and harmless backport. I'd still backport it but it is of course not that important.
  12. Nicole Hummel commented on patch set 3 09/19/16, 10:20

    Why is the partial called SererInfo while it is dealing with the time only?
  13. Daniel Goerz commented on patch set 3 09/20/16, 07:51

    > Why is the partial called SererInfo while it is dealing with the > time only? Frankly, I didn't put much thought into it. I guess one could rename it or just go with ServerInfo as there might be more information than the time to be shown in the future.
  14. Stefan Neufeind commented on patch set 3 09/22/16, 21:48

    Both namings are fine with me - ServerInfo since it's general (but I don't know what else we will later put into that partial) or just ServerTime since it's the only thing we currently use it for.
  15. Daniel Goerz commented on patch set 3 09/26/16, 12:53

    So, should I rename the partial or can we merge this?
  16. Nicole Hummel commented on patch set 3 CR -1 09/26/16, 12:56

    I would recommend to rename the partial and remove the 7.6 from releases in commit message.
  17. Daniel Goerz uploaded patch set 4 09/26/16, 13:07

  18. TYPO3com voted on patch set 4 V +1 09/26/16, 13:11 Completed build in 03m 34s on Mon, 26 Sep, 03:11 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3217

  19. Nicole Hummel voted on patch set 4 CR +1 09/26/16, 13:14

  20. Ralf Merz voted on patch set 4 CR +1 09/26/16, 13:38

  21. Jörg Bösche voted on patch set 4 CR +1 09/26/16, 19:09

  22. Stefan Neufeind voted on patch set 4 CR +1 V +1 09/27/16, 06:14

  23. Robert van Kammen voted on patch set 4 CR +1 V +1 09/28/16, 07:28

  24. Wouter Wolters voted on patch set 4 CR +2 V +2 09/28/16, 07:34

  25. Gerrit merged patch set 4 09/28/16, 07:34