49853[TASK] Scheduler: Move server time info to a partial
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Ralf Merz +1
- Robert van Kammen +1
- Jörg Bösche +1
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Robert van Kammen +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+13 −8
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/ServerTime.htmlnew+6 −0
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/CheckScreen.html+2 −0
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/EditTask.html+1 −3
- typo3/sysext/scheduler/Resources/Private/Templates/Backend/SchedulerModule/ListTasks.html+1 −3
Review log 2327
Show 12 earlier messages
-
Daniel Goerz uploaded patch set 1 09/04/16, 09:19
-
TYPO3com voted on patch set 1 V +1 09/04/16, 09:22 Completed build in 03m 11s on Sun, 4 Sep, 11:22 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2961
-
Daniel Maier voted on patch set 1 CR +1 09/04/16, 09:36
-
Daniel Goerz commented on patch set 1 CR -1 09/04/16, 09:37
still on it -
Daniel Goerz uploaded patch set 2 09/04/16, 09:46
-
Daniel Goerz uploaded patch set 3 09/04/16, 09:47
-
Daniel Goerz commented on patch set 3 09/04/16, 09:49
I added the info to the check view because it makes total sense to not exclude one important information about the setup (server time) there. -
TYPO3com voted on patch set 2 V +1 09/04/16, 09:52 Completed build in 06m 17s on Sun, 4 Sep, 11:52 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2967
-
TYPO3com voted on patch set 3 V +1 09/04/16, 09:55 Completed build in 07m 54s on Sun, 4 Sep, 11:55 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2970
-
Ralf Merz voted on patch set 3 CR +1 V +1 09/07/16, 07:47
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 09/13/16, 07:50
-
Stefan Neufeind commented on patch set 3 CR +1 V +1 09/19/16, 08:14
imho not for 7.6 as it isn't important -
Daniel Goerz commented on patch set 3 09/19/16, 08:30
> (1 comment) Sure. Not mandatory. But an UI and usability improvement that should be a straight and harmless backport. I'd still backport it but it is of course not that important. -
Nicole Hummel commented on patch set 3 09/19/16, 10:20
Why is the partial called SererInfo while it is dealing with the time only? -
Daniel Goerz commented on patch set 3 09/20/16, 07:51
> Why is the partial called SererInfo while it is dealing with the > time only? Frankly, I didn't put much thought into it. I guess one could rename it or just go with ServerInfo as there might be more information than the time to be shown in the future. -
Stefan Neufeind commented on patch set 3 09/22/16, 21:48
Both namings are fine with me - ServerInfo since it's general (but I don't know what else we will later put into that partial) or just ServerTime since it's the only thing we currently use it for. -
Daniel Goerz commented on patch set 3 09/26/16, 12:53
So, should I rename the partial or can we merge this? -
Nicole Hummel commented on patch set 3 CR -1 09/26/16, 12:56
I would recommend to rename the partial and remove the 7.6 from releases in commit message. -
Daniel Goerz uploaded patch set 4 09/26/16, 13:07
-
TYPO3com voted on patch set 4 V +1 09/26/16, 13:11 Completed build in 03m 34s on Mon, 26 Sep, 03:11 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3217
-
Nicole Hummel voted on patch set 4 CR +1 09/26/16, 13:14
-
Ralf Merz voted on patch set 4 CR +1 09/26/16, 13:38
-
Jörg Bösche voted on patch set 4 CR +1 09/26/16, 19:09
-
Stefan Neufeind voted on patch set 4 CR +1 V +1 09/27/16, 06:14
-
Robert van Kammen voted on patch set 4 CR +1 V +1 09/28/16, 07:28
-
Wouter Wolters voted on patch set 4 CR +2 V +2 09/28/16, 07:34
-
Gerrit merged patch set 4 09/28/16, 07:34