Review main Merged

49858[TASK] Add crosslinks to Forge in ChangeLogs

Martin Bless CR +2 V +2 Hard +590 −0 updated 09/08/16, 20:15

Commit message

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Ernesto Baschny +1
    • Martin Bless +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Ernesto Baschny +1
    • Martin Bless +1
    • TYPO3com +1 CI

Issues 1

Files 295

Show 275 more files

Review log 1215

  1. Martin Bless uploaded patch set 1 09/04/16, 14:17

  2. TYPO3com voted on patch set 1 V +1 09/04/16, 14:21 Completed build in 03m 26s on Sun, 4 Sep, 04:21 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2978

  3. Philipp Gampe voted on patch set 1 CR +1 09/05/16, 15:51

  4. Martin Bless uploaded patch set 2 09/05/16, 21:06

  5. TYPO3com voted on patch set 2 V +1 09/05/16, 21:10 Completed build in 03m 27s on Mon, 5 Sep, 11:10 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2996

  6. Martin Bless commented on patch set 2 CR +1 V +1 09/05/16, 21:10

    It seems better to use :issue: for links to Forge. Later we can use :review: in the same manner for links to review.typo3.org.
  7. Ernesto Baschny uploaded patch set 3 09/06/16, 19:20

  8. TYPO3com voted on patch set 3 V +1 09/06/16, 19:24 Completed build in 03m 35s on Tue, 6 Sep, 09:24 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3008

  9. Ernesto Baschny commented on patch set 3 CR +1 V +1 09/06/16, 19:25

    I just updated the patchset to resolve the conflict (change 77727 was reverted meanwhile). Looks fine!
  10. Martin Bless commented on patch set 3 CR +1 V +1 09/06/16, 21:59

    Very useful! Good looking and tested!
  11. Mathias Brodala commented on patch set 3 09/07/16, 06:34

    Would it be possible to link the ticket number in the change headline instead? This way we can avoid duplicating it and reduce clutter.
  12. Martin Bless commented on patch set 3 09/07/16, 09:47

    Might work in the headline, but has other drawbacks and will probably at some point cause trouble. I would recommend the way given here.
  13. Mathias Brodala commented on patch set 3 09/07/16, 10:15

    OK, thanks for considering. :-)
  14. Tymoteusz Motylewski voted on patch set 3 CR +2 V +2 09/08/16, 20:15

  15. Gerrit merged patch set 3 09/08/16, 20:15